Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Unified Diff: third_party/WebKit/Source/core/html/HTMLFieldSetElement.h

Issue 2548453003: FIELDSET element: |elements| IDL attribute should return an HTMLCollection, not HTMLFormControlsCol… (Closed)
Patch Set: blank lines Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLFieldSetElement.h
diff --git a/third_party/WebKit/Source/core/html/HTMLFieldSetElement.h b/third_party/WebKit/Source/core/html/HTMLFieldSetElement.h
index b47d303ec11c531600d748a757fa214a5fe5f824..226fffcb738d72b5fec2e3a66c77fb36b014a2d0 100644
--- a/third_party/WebKit/Source/core/html/HTMLFieldSetElement.h
+++ b/third_party/WebKit/Source/core/html/HTMLFieldSetElement.h
@@ -29,7 +29,7 @@
namespace blink {
-class HTMLFormControlsCollection;
+class HTMLCollection;
class CORE_EXPORT HTMLFieldSetElement final : public HTMLFormControlElement {
DEFINE_WRAPPERTYPEINFO();
@@ -38,10 +38,7 @@ class CORE_EXPORT HTMLFieldSetElement final : public HTMLFormControlElement {
static HTMLFieldSetElement* create(Document&, HTMLFormElement*);
DECLARE_VIRTUAL_TRACE();
HTMLLegendElement* legend() const;
-
- HTMLFormControlsCollection* elements();
-
- const FormAssociatedElement::List& associatedElements() const;
+ HTMLCollection* elements();
protected:
void disabledAttributeChanged() override;
@@ -64,7 +61,9 @@ class CORE_EXPORT HTMLFieldSetElement final : public HTMLFormControlElement {
static void invalidateDisabledStateUnder(Element&);
void refreshElementsIfNeeded() const;
+ const FormAssociatedElement::List& associatedElements() const;
+ // TODO(tkent): Remove m_associcatedElements.
mutable FormAssociatedElement::List m_associatedElements;
// When dom tree is modified, we have to refresh the m_associatedElements
// array.
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLCollection.cpp ('k') | third_party/WebKit/Source/core/html/HTMLFieldSetElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698