Don't commit prefs::kStabilitySessionEndCompleted change immediately on chromeos

chrome/browser/metrics/metrics_service.h

Index: chrome/browser/metrics/metrics_service.h
diff --git a/chrome/browser/metrics/metrics_service.h b/chrome/browser/metrics/metrics_service.h
index a35da3dbf886360390658c2935f181a1fd22d1de..6dfa6482bc092c23c2c3bcd756a3754d8dcbab1f 100644
--- a/chrome/browser/metrics/metrics_service.h
+++ b/chrome/browser/metrics/metrics_service.h
@@ -367,8 +367,9 @@ class MetricsService
   // Records a renderer process hang.
   void LogRendererHang();
 
-  // Records that the browser was shut down cleanly.
-  void LogCleanShutdown();
+  // Records that the browser was shutdown cleanly, and the value of
+  // |kStatabilitySessionEndCompleted|.

[jar (doing other things), 2013/10/11 22:55:44]

nit: I think you didn't finish this sentence.  

Also, when you use the "|" around a name, it usually means the variable by said
name.  In this case, you're talking about a pref that has a given name, and
setting its value.  Clearer might be:

It also sets the boolean preference "kStatabilitySessionEndCompleted" to the
specified |value|.

It is probably critical to say which was done first, especially if one of them
commits preference values (writes them to disk).

+  void RecordStabilitySessionEndCompleted(bool value);
 
   // Returns reference to ChildProcessStats corresponding to |data|.
   ChildProcessStats& GetChildProcessStats(
@@ -389,9 +390,6 @@ class MetricsService
   // Checks whether a notification can be logged.
   bool CanLogNotification();
 
-  // Sets the value of the specified path in prefs and schedules a save.
-  void RecordBooleanPrefValue(const char* path, bool value);
-
   // Returns true if process of type |type| should be counted as a plugin
   // process, and false otherwise.
   static bool IsPluginProcess(int process_type);