Don't commit prefs::kStabilitySessionEndCompleted change immediately on chromeos

chrome/browser/metrics/metrics_service.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file defines a service that collects information about the user
 // experience in order to help improve future versions of the app.
 
 #ifndef CHROME_BROWSER_METRICS_METRICS_SERVICE_H_
 #define CHROME_BROWSER_METRICS_METRICS_SERVICE_H_
 
@@ skipping 349 matching lines @@
   void IncrementLongPrefsValue(const char* path);
 
   // Records a renderer process crash.
   void LogRendererCrash(content::RenderProcessHost* host,
                         base::TerminationStatus status,
                         int exit_code);
 
   // Records a renderer process hang.
   void LogRendererHang();
 
-  // Records that the browser was shut down cleanly.
-  void LogCleanShutdown();
+  // Records that the browser was shutdown cleanly, and the value of
+  // |kStatabilitySessionEndCompleted|.

[jar (doing other things), 2013/10/11 22:55:44]

nit: I think you didn't finish this sentence.  

Also, when you use the "|" around a name, it usually means the variable by said
name.  In this case, you're talking about a pref that has a given name, and
setting its value.  Clearer might be:

It also sets the boolean preference "kStatabilitySessionEndCompleted" to the
specified |value|.

It is probably critical to say which was done first, especially if one of them
commits preference values (writes them to disk).

+  void RecordStabilitySessionEndCompleted(bool value);
 
   // Returns reference to ChildProcessStats corresponding to |data|.
   ChildProcessStats& GetChildProcessStats(
       const content::ChildProcessData& data);
 
   // Saves plugin-related updates from the in-object buffer to Local State
   // for retrieval next time we send a Profile log (generally next launch).
   void RecordPluginChanges(PrefService* pref);
 
   // Records state that should be periodically saved, like uptime and
   // buffered plugin stability statistics.
   void RecordCurrentState(PrefService* pref);
 
   // Logs the initiation of a page load and uses |web_contents| to do
   // additional logging of the type of page loaded.
   void LogLoadStarted(content::WebContents* web_contents);
 
   // Checks whether a notification can be logged.
   bool CanLogNotification();
 
-  // Sets the value of the specified path in prefs and schedules a save.
-  void RecordBooleanPrefValue(const char* path, bool value);
-
   // Returns true if process of type |type| should be counted as a plugin
   // process, and false otherwise.
   static bool IsPluginProcess(int process_type);
 
   content::ActionCallback action_callback_;
 
   content::NotificationRegistrar registrar_;
 
   // Indicate whether recording and reporting are currently happening.
   // These should not be set directly, but by calling SetRecording and
@@ skipping 105 matching lines @@
   friend class extensions::ExtensionDownloader;
   friend class extensions::ManifestFetchData;
 
   // Returns true if prefs::kMetricsReportingEnabled is set.
   static bool IsMetricsReportingEnabled();
 
   DISALLOW_IMPLICIT_CONSTRUCTORS(MetricsServiceHelper);
 };
 
 #endif  // CHROME_BROWSER_METRICS_METRICS_SERVICE_H_