Extend more runtime envs for generateMipmap srgb emulation

Extend more runtime envs for generateMipmap srgb emulation

Add entries for windows, chromeos, and linux mesa in gpu_driver_bug_list.
Generate shaders according to different gl contexts.

BUG=634519
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/bc15e2a59cd6f9f124b5b55ee4f14348ab6717ee
Cr-Commit-Position: refs/heads/master@{#437398}

[yizhou.jiang, 2016-12-05 15:21:56]

Description was changed from

==========
Add entries for windows in gpu/config/gpu_driver_bug_list_json.cc to enable srgb
format generateMipmap on windows.


Fix es context

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

patch from issue 2551033002 at patchset 1 (http://crrev.com/2551033002#ps1)
==========

to

==========
Add entries for windows in gpu/config/gpu_driver_bug_list_json.cc
to enable srgb format generateMipmap on windows.


Fix es context

BUG=634519
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

patch from issue 2551033002 at patchset 1 (http://crrev.com/2551033002#ps1)
==========

[yizhou.jiang, 2016-12-05 15:25:47]

Patchset #1 (id:1) has been deleted

[yizhou.jiang, 2016-12-05 15:26:46]

yizhou.jiang@intel.com changed reviewers:
+ qiankun.miao@intel.com, yunchao.he@intel.com

[yizhou.jiang, 2016-12-06 02:29:51]

Patchset #2 (id:40001) has been deleted

[yunchao, 2016-12-06 02:46:16]

https://codereview.chromium.org/2548363002/diff/60001/gpu/config/gpu_driver_b...
File gpu/config/gpu_driver_bug_list_json.cc (right):

https://codereview.chromium.org/2548363002/diff/60001/gpu/config/gpu_driver_b...
gpu/config/gpu_driver_bug_list_json.cc:2245: "features" :
["decode_encode_srgb_for_generatemipmap"
Could you tighten the condition? 

In addition, what about gles?

[yizhou.jiang, 2016-12-06 03:08:58]

Patchset #2 (id:60001) has been deleted

[yizhou.jiang, 2016-12-06 03:09:22]

Patchset #2 (id:80001) has been deleted

[yizhou.jiang, 2016-12-06 05:46:01]

Patchset #3 (id:120001) has been deleted

[yizhou.jiang, 2016-12-06 06:08:54]

Patchset #3 (id:140001) has been deleted

[yizhou.jiang, 2016-12-06 08:06:04]

Patchset #3 (id:160001) has been deleted

[yizhou.jiang, 2016-12-06 08:16:17]

On 2016/12/06 02:46:16, yunchao wrote:
>
https://codereview.chromium.org/2548363002/diff/60001/gpu/config/gpu_driver_b...
> File gpu/config/gpu_driver_bug_list_json.cc (right):
> 
>
https://codereview.chromium.org/2548363002/diff/60001/gpu/config/gpu_driver_b...
> gpu/config/gpu_driver_bug_list_json.cc:2245: "features" :
> ["decode_encode_srgb_for_generatemipmap"
> Could you tighten the condition? 
> 
> In addition, what about gles?

@yunchao and @qiankun. I have updated the code, PTAL.

[yizhou.jiang, 2016-12-06 10:58:12]

Patchset #5 (id:220001) has been deleted

[yizhou.jiang, 2016-12-06 11:19:26]

Patchset #5 (id:240001) has been deleted

[yizhou.jiang, 2016-12-06 11:30:19]

Description was changed from

==========
Add entries for windows in gpu/config/gpu_driver_bug_list_json.cc
to enable srgb format generateMipmap on windows.


Fix es context

BUG=634519
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

patch from issue 2551033002 at patchset 1 (http://crrev.com/2551033002#ps1)
==========

to

==========
Add entries for windows, chromeos, and linux mesa in gpu_driver_bug_list.
Modify Shaders according to different gl version.



BUG=634519
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

patch from issue 2551033002 at patchset 1 (http://crrev.com/2551033002#ps1)
==========

[yizhou.jiang, 2016-12-06 12:02:13]

Patchset #5 (id:260001) has been deleted

[yizhou.jiang, 2016-12-06 12:07:55]

Patchset #5 (id:280001) has been deleted

[yizhou.jiang, 2016-12-06 12:11:31]

Patchset #5 (id:300001) has been deleted

[yizhou.jiang, 2016-12-06 12:16:51]

Patchset #5 (id:320001) has been deleted

[yizhou.jiang, 2016-12-06 12:20:39]

Patchset #5 (id:340001) has been deleted

[yizhou.jiang, 2016-12-07 12:44:35]

Patchset #7 (id:400001) has been deleted

[yizhou.jiang, 2016-12-07 14:12:54]

yizhou.jiang@intel.com changed reviewers:
+ kbr@chromium.org, zmo@chromium.org

[yizhou.jiang, 2016-12-07 14:22:16]

@zmo and @kbr, I have add some entries into gpu_driver_bug_list_json.cc for
Windows, Linux and chromeos, and revise shaders according to gl version,PTAL.

[qiankun, 2016-12-07 17:48:08]

Description was changed from

==========
Add entries for windows, chromeos, and linux mesa in gpu_driver_bug_list.
Modify Shaders according to different gl version.



BUG=634519
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

patch from issue 2551033002 at patchset 1 (http://crrev.com/2551033002#ps1)
==========

to

==========
Extend more runtime envs for generateMipmap srgb emulation

Add entries for windows, chromeos, and linux mesa in gpu_driver_bug_list.
Generate shaders according to different gl contexts.

BUG=634519

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

patch from issue 2551033002 at patchset 1 (http://crrev.com/2551033002#ps1)
==========

[qiankun, 2016-12-07 17:48:30]

Description was changed from

==========
Extend more runtime envs for generateMipmap srgb emulation

Add entries for windows, chromeos, and linux mesa in gpu_driver_bug_list.
Generate shaders according to different gl contexts.

BUG=634519

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

patch from issue 2551033002 at patchset 1 (http://crrev.com/2551033002#ps1)
==========

to

==========
Extend more runtime envs for generateMipmap srgb emulation

Add entries for windows, chromeos, and linux mesa in gpu_driver_bug_list.
Generate shaders according to different gl contexts.

BUG=634519

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Zhenyao Mo, 2016-12-07 22:50:39]

lgtm

https://codereview.chromium.org/2548363002/diff/420001/gpu/command_buffer/ser...
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

https://codereview.chromium.org/2548363002/diff/420001/gpu/command_buffer/ser...
gpu/command_buffer/service/gles2_cmd_decoder.cc:6162: // TODO(yizhou): If the
target is GL_TEXTURE_3D or GL_TEXTURE_2D_ARRAY,
Just noticed: what about CUBEMAP?

[Ken Russell (switch to Gerrit), 2016-12-07 22:54:47]

I defer to zmo's review, but this looks OK to me (modulo his question about cube
map textures).

[yizhou.jiang, 2016-12-08 00:34:26]

The CQ bit was checked by yizhou.jiang@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 00:35:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yizhou.jiang, 2016-12-08 00:35:10]

The CQ bit was unchecked by yizhou.jiang@intel.com

[yizhou.jiang, 2016-12-08 00:35:37]

The CQ bit was checked by yizhou.jiang@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 00:36:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 01:41:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 01:41:34]

Dry run: This issue passed the CQ dry run.

[yizhou.jiang, 2016-12-08 01:59:13]

The CQ bit was checked by yizhou.jiang@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 01:59:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yizhou.jiang, 2016-12-08 02:02:30]

On 2016/12/07 22:50:39, Zhenyao Mo wrote:
> lgtm
> 
>
https://codereview.chromium.org/2548363002/diff/420001/gpu/command_buffer/ser...
> File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):
> 
>
https://codereview.chromium.org/2548363002/diff/420001/gpu/command_buffer/ser...
> gpu/command_buffer/service/gles2_cmd_decoder.cc:6162: // TODO(yizhou): If the
> target is GL_TEXTURE_3D or GL_TEXTURE_2D_ARRAY,
> Just noticed: what about CUBEMAP?

Add to TODO list.

[yizhou.jiang, 2016-12-08 02:05:00]

The CQ bit was checked by yizhou.jiang@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 02:05:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 03:49:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 03:49:58]

Dry run: Try jobs failed on following builders:
  mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)

[yizhou.jiang, 2016-12-08 05:38:59]

The CQ bit was checked by yizhou.jiang@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 05:39:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yizhou.jiang, 2016-12-08 05:40:50]

Patchset #9 (id:460001) has been deleted

[commit-bot: I haz the power, 2016-12-08 05:42:11]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
  win_optional_gpu_tests_rel on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_...)

[yizhou.jiang, 2016-12-08 05:56:55]

The CQ bit was checked by yizhou.jiang@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 05:57:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yizhou.jiang, 2016-12-08 05:57:55]

Patchset #8 (id:440001) has been deleted

[commit-bot: I haz the power, 2016-12-08 06:44:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 06:44:24]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[yizhou.jiang, 2016-12-08 10:28:47]

The CQ bit was checked by yizhou.jiang@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 10:29:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 11:31:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 11:31:11]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[yizhou.jiang, 2016-12-08 13:35:58]

The CQ bit was checked by yizhou.jiang@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 13:36:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 15:03:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 15:03:50]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[yizhou.jiang, 2016-12-08 15:10:58]

The CQ bit was checked by yizhou.jiang@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 15:11:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 16:37:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 16:37:36]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Zhenyao Mo, 2016-12-08 17:59:46]

The CQ bit was checked by zmo@chromium.org

[Zhenyao Mo, 2016-12-08 17:59:47]

The patchset sent to the CQ was uploaded after l-g-t-m from zmo@chromium.org
Link to the patchset: https://codereview.chromium.org/2548363002/#ps480001
(title: "Addressed feedback:Add CubeMap to TODO")

[commit-bot: I haz the power, 2016-12-08 18:00:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 20:00:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 20:00:37]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Ken Russell (switch to Gerrit), 2016-12-08 23:47:12]

On 2016/12/08 20:00:37, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
>
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

android_n5x_swarming_rel's been removed from the CQ due to
http://crbug.com/672382 . Re-CQ'ing.

[Ken Russell (switch to Gerrit), 2016-12-08 23:47:19]

The CQ bit was checked by kbr@chromium.org

[commit-bot: I haz the power, 2016-12-08 23:47:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 01:11:38]

CQ is committing da patch.

Bot data: {"patchset_id": 480001, "attempt_start_ts": 1481240839092930,
"parent_rev": "5c11458a4052033fb05c8fb75b3a8b058ab19424", "commit_rev":
"b5e23960553833034aeaf2197e94ab8e907d1fd6"}

[commit-bot: I haz the power, 2016-12-09 01:12:21]

Description was changed from

==========
Extend more runtime envs for generateMipmap srgb emulation

Add entries for windows, chromeos, and linux mesa in gpu_driver_bug_list.
Generate shaders according to different gl contexts.

BUG=634519

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Extend more runtime envs for generateMipmap srgb emulation

Add entries for windows, chromeos, and linux mesa in gpu_driver_bug_list.
Generate shaders according to different gl contexts.

BUG=634519

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-12-09 01:12:22]

Committed patchset #8 (id:480001)

[commit-bot: I haz the power, 2016-12-09 01:14:37]

Description was changed from

==========
Extend more runtime envs for generateMipmap srgb emulation

Add entries for windows, chromeos, and linux mesa in gpu_driver_bug_list.
Generate shaders according to different gl contexts.

BUG=634519

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Extend more runtime envs for generateMipmap srgb emulation

Add entries for windows, chromeos, and linux mesa in gpu_driver_bug_list.
Generate shaders according to different gl contexts.

BUG=634519

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/bc15e2a59cd6f9f124b5b55ee4f14348ab6717ee
Cr-Commit-Position: refs/heads/master@{#437398}
==========

[commit-bot: I haz the power, 2016-12-09 01:14:38]

Patchset 8 (id:??) landed as
https://crrev.com/bc15e2a59cd6f9f124b5b55ee4f14348ab6717ee
Cr-Commit-Position: refs/heads/master@{#437398}

[yizhou.jiang, 2016-12-09 03:28:22]

On 2016/12/08 23:47:12, Ken Russell wrote:
> On 2016/12/08 20:00:37, commit-bot: I haz the power wrote:
> > Try jobs failed on following builders:
> >   android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
> >
>
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
> 
> android_n5x_swarming_rel's been removed from the CQ due to
> http://crbug.com/672382 . Re-CQ'ing.

@kbr, thanks a lot for your help with the trybots issue.