third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h - Issue 2548333004: Fix not to double count the widths of hyphens

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h

Issue 2548333004: Fix not to double count the widths of hyphens (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h

diff --git a/third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h b/third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h

index 75cb21f4da3fb17f7bf03bf87dcbe8cd16b8b63e..93b903dc025500b30ba891a488793a1dc6432967 100644

--- a/third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h

+++ b/third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h

@@ -892,7 +892,7 @@ ALWAYS_INLINE bool BreakingContext::hyphenate(

// ignores the kerning between the last letter and the hyphen.

return rewindToMidWordBreak(

wordMeasurement, start + prefixLength,

- font.getCharacterRange(run, 0, prefixLength).width() + hyphenWidth);

+ font.getCharacterRange(run, 0, prefixLength).width());

}

ALWAYS_INLINE bool BreakingContext::isBreakAtSoftHyphen() const {

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/text/hyphens/hyphens-align-expected.html ('k') | no next file » | no next file with comments »