Issue 254833004: DevTools: [Console] use filtering to collapse and expand console groups

Issue 254833004: DevTools: [Console] use filtering to collapse and expand console groups (Closed)

Created:
6 years, 8 months ago by lushnikov

Modified:
6 years, 7 months ago

Reviewers:
sergeyv, pfeldman

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

DevTools: [Console] use filtering to collapse and expand console groups Collapsing/expanding groups in console is just a special case of console message filtering. This patch unifies codepaths for both filtering and group collapsing, simplifies ConsoleGroup and introduces additional ConsoleGroupViewMessage which tracks if the group is collapsed. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172739

Patch Set 1 #

Patch Set 2 : update tests #

Total comments: 3

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+142 lines, -193 lines)			Patch
M	LayoutTests/inspector/console/console-big-array.html	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/inspector/console/console-dir.html	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/inspector/console/console-dir-deprecated.html	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/inspector/console/console-filter-level-test.html	View	1	1 chunk	+1 line, -3 lines	0 comments	Download
M	LayoutTests/inspector/console/console-filter-test.html	View	1	1 chunk	+4 lines, -4 lines	0 comments	Download
M	LayoutTests/inspector/console/console-tests-expected.txt	View	1	1 chunk	+0 lines, -10 lines	1 comment	Download
M	Source/devtools/front_end/console/ConsoleView.js	View	1	7 chunks	+63 lines, -160 lines	2 comments	Download
M	Source/devtools/front_end/console/ConsoleViewMessage.js	View	1	3 chunks	+62 lines, -13 lines	0 comments	Download
M	Source/devtools/front_end/sdk/ConsoleModel.js	View		1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

pfeldman

lgtm https://codereview.chromium.org/254833004/diff/20001/LayoutTests/inspector/console/console-tests-expected.txt File LayoutTests/inspector/console/console-tests-expected.txt (left): https://codereview.chromium.org/254833004/diff/20001/LayoutTests/inspector/console/console-tests-expected.txt#oldcode35 LayoutTests/inspector/console/console-tests-expected.txt:35: Object console-tests.html:22 console-message console-log-level Where did this go? ...

6 years, 7 months ago (2014-04-28 09:00:32 UTC) #3

lushnikov

On 2014/04/28 09:00:32, pfeldman wrote: > lgtm > > https://codereview.chromium.org/254833004/diff/20001/LayoutTests/inspector/console/console-tests-expected.txt > File LayoutTests/inspector/console/console-tests-expected.txt (left): > ...

6 years, 7 months ago (2014-04-28 09:15:22 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/254833004/20001

6 years, 7 months ago (2014-04-28 09:15:40 UTC) #6

Message was sent while issue was closed.

Change committed as 172739

Expand Messages | Collapse Messages