Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1552)

Unified Diff: Source/devtools/front_end/console/ConsoleViewMessage.js

Issue 254833004: DevTools: [Console] use filtering to collapse and expand console groups (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: update tests Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/console/ConsoleViewMessage.js
diff --git a/Source/devtools/front_end/console/ConsoleViewMessage.js b/Source/devtools/front_end/console/ConsoleViewMessage.js
index 99f3c5e3e2e313c1371319725f87b0fef6c2d62f..89864a591cb226d852dc093289078810ff11f5c5 100644
--- a/Source/devtools/front_end/console/ConsoleViewMessage.js
+++ b/Source/devtools/front_end/console/ConsoleViewMessage.js
@@ -901,25 +901,25 @@ WebInspector.ConsoleViewMessage.prototype = {
return this._nestingLevel;
},
- /**
- * @return {number}
- */
- closeGroupDecorationCount: function()
+ resetCloseGroupDecorationCount: function()
{
- return this._closeGroupDecorationCount;
+ this._closeGroupDecorationCount = 0;
+ this._updateCloseGroupDecorations();
},
- /**
- * @param {number} count
- */
- setCloseGroupDecorationCount: function(count)
+ incrementCloseGroupDecorationCount: function()
{
- this._closeGroupDecorationCount = count;
- if (!this._element)
- this.toMessageElement();
+ ++this._closeGroupDecorationCount;
+ this._updateCloseGroupDecorations();
+ },
+
+ _updateCloseGroupDecorations: function()
+ {
+ if (!this._nestingLevelMarkers)
+ return;
for (var i = 0, n = this._nestingLevelMarkers.length; i < n; ++i) {
var marker = this._nestingLevelMarkers[i];
- marker.classList.toggle("group-closed", n - i <= count);
+ marker.classList.toggle("group-closed", n - i <= this._closeGroupDecorationCount);
}
},
@@ -977,6 +977,7 @@ WebInspector.ConsoleViewMessage.prototype = {
this._nestingLevelMarkers = [];
for (var i = 0; i < this._nestingLevel; ++i)
this._nestingLevelMarkers.push(this._wrapperElement.createChild("div", "nesting-level-marker"));
+ this._updateCloseGroupDecorations();
this._wrapperElement.message = this;
this._wrapperElement.appendChild(this.contentElement());
@@ -1140,3 +1141,51 @@ WebInspector.ConsoleViewMessage.prototype = {
__proto__: WebInspector.TargetAware.prototype
}
+
+/**
+ * @constructor
+ * @extends {WebInspector.ConsoleViewMessage}
+ * @param {!WebInspector.ConsoleMessage} consoleMessage
+ * @param {?WebInspector.Linkifier} linkifier
+ * @param {number} nestingLevel
+ */
+WebInspector.ConsoleGroupViewMessage = function(consoleMessage, linkifier, nestingLevel)
+{
+ console.assert(consoleMessage.isGroupStartMessage());
+ WebInspector.ConsoleViewMessage.call(this, consoleMessage, linkifier, nestingLevel);
+ this.setCollapsed(consoleMessage.type === WebInspector.ConsoleMessage.MessageType.StartGroupCollapsed);
+}
+
+WebInspector.ConsoleGroupViewMessage.prototype = {
+ /**
+ * @param {boolean} collapsed
+ */
+ setCollapsed: function(collapsed)
+ {
+ this._collapsed = collapsed;
+ if (this._wrapperElement)
+ this._wrapperElement.classList.toggle("collapsed", this._collapsed);
+ },
+
+ /**
+ * @return {boolean}
+ */
+ collapsed: function()
+ {
+ return this._collapsed;
+ },
+
+ /**
+ * @return {!Element}
+ */
+ toMessageElement: function()
+ {
+ if (!this._wrapperElement) {
+ WebInspector.ConsoleViewMessage.prototype.toMessageElement.call(this);
+ this._wrapperElement.classList.toggle("collapsed", this._collapsed);
+ }
+ return this._wrapperElement;
+ },
+
+ __proto__: WebInspector.ConsoleViewMessage.prototype
+}

Powered by Google App Engine
This is Rietveld 408576698