Add comments for the usage of Chrome and Google strings and logos.

Add comments for the usage of Chrome and Google strings and logos.

This CL adds explinatory comments for the usage of Chrome and Google strings
and logos in Chromium builds for the sync confirmation dialog.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/c4cf1373ab4f2201e969159d97565e225850cbcd
Cr-Commit-Position: refs/heads/master@{#436339}

[msarda, 2016-12-05 10:04:44]

Description was changed from

==========
Add comments for the usage of Chrome and Google strings and logos.

This CL adds explinatory comments for the usage of Chrome and Google strings
and logos in Chromium builds for the sync confirmation dialog.
==========

to

==========
Add comments for the usage of Chrome and Google strings and logos.

This CL adds explinatory comments for the usage of Chrome and Google strings
and logos in Chromium builds for the sync confirmation dialog.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[msarda, 2016-12-05 10:08:02]

Patchset #1 (id:1) has been deleted

[msarda, 2016-12-05 10:19:26]

Patchset #1 (id:20001) has been deleted

[msarda, 2016-12-05 10:19:32]

Patchset #1 (id:40001) has been deleted

[msarda, 2016-12-05 10:19:38]

Patchset #1 (id:60001) has been deleted

[msarda, 2016-12-05 10:21:17]

msarda@chromium.org changed reviewers:
+ rohitrao@chromium.org

[msarda, 2016-12-05 10:21:18]

Please take a look.

[msarda, 2016-12-05 10:21:34]

Description was changed from

==========
Add comments for the usage of Chrome and Google strings and logos.

This CL adds explinatory comments for the usage of Chrome and Google strings
and logos in Chromium builds for the sync confirmation dialog.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Add comments for the usage of Chrome and Google strings and logos.

This CL adds explinatory comments for the usage of Chrome and Google strings
and logos in Chromium builds for the sync confirmation dialog.
==========

[rohitrao (ping after 24h), 2016-12-05 12:52:42]

LGTM

Should we make the corresponding changes in
ios/chrome/app/strings/ios_strings.grd?

[msarda, 2016-12-05 13:31:56]

Description was changed from

==========
Add comments for the usage of Chrome and Google strings and logos.

This CL adds explinatory comments for the usage of Chrome and Google strings
and logos in Chromium builds for the sync confirmation dialog.
==========

to

==========
Add comments for the usage of Chrome and Google strings and logos.

This CL adds explinatory comments for the usage of Chrome and Google strings
and logos in Chromium builds for the sync confirmation dialog.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[msarda, 2016-12-05 13:32:42]

On 2016/12/05 12:52:42, rohitrao wrote:
> LGTM
> 
> Should we make the corresponding changes in
> ios/chrome/app/strings/ios_strings.grd?

Done.

[msarda, 2016-12-05 13:33:03]

The CQ bit was checked by msarda@chromium.org

[msarda, 2016-12-05 13:33:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
rohitrao@chromium.org
Link to the patchset: https://codereview.chromium.org/2548303002/#ps120001
(title: "Nit")

[commit-bot: I haz the power, 2016-12-05 13:33:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-05 13:39:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-05 13:39:58]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[msarda, 2016-12-05 13:44:57]

msarda@chromium.org changed reviewers:
+ xiyuan@chromium.org

[msarda, 2016-12-05 13:44:58]

xiyuan@chromium.org: Please review changes in 
chrome/browser/resources/signin/sync_confirmation/sync_confirmation.html

[xiyuan, 2016-12-05 16:58:42]

c/b/resources/signin/sync_confirmation/sync_confirmation.html lgtm

[msarda, 2016-12-05 17:08:28]

The CQ bit was checked by msarda@chromium.org

[msarda, 2016-12-05 17:08:45]

Thank you for the review.

[commit-bot: I haz the power, 2016-12-05 17:08:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-05 17:48:57]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1480957708243760,
"parent_rev": "c25492b03dd86cdcde58844b42ca233790769338", "commit_rev":
"5ea84bbe20f47581b5cf971da6c6e555b8d31ad6"}

[commit-bot: I haz the power, 2016-12-05 17:49:25]

Committed patchset #3 (id:120001)

[commit-bot: I haz the power, 2016-12-05 17:52:59]

Description was changed from

==========
Add comments for the usage of Chrome and Google strings and logos.

This CL adds explinatory comments for the usage of Chrome and Google strings
and logos in Chromium builds for the sync confirmation dialog.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Add comments for the usage of Chrome and Google strings and logos.

This CL adds explinatory comments for the usage of Chrome and Google strings
and logos in Chromium builds for the sync confirmation dialog.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/c4cf1373ab4f2201e969159d97565e225850cbcd
Cr-Commit-Position: refs/heads/master@{#436339}
==========

[commit-bot: I haz the power, 2016-12-05 17:53:00]

Patchset 3 (id:??) landed as
https://crrev.com/c4cf1373ab4f2201e969159d97565e225850cbcd
Cr-Commit-Position: refs/heads/master@{#436339}