Revert of Use the modal view when signing in from chrome.identity extension API.

Revert of Use the modal view when signing in from chrome.identity extension API. (patchset #2 id:10001 of https://codereview.chromium.org/2462603002/ )

Reason for revert:
This CL as it is responsible for crash
https://bugs.chromium.org/p/chromium/issues/detail?id=667750

Original issue's description:
> Use the modal view when signing in from chrome.identity extension API.
>
> BUG=652791
>
> Committed: https://crrev.com/8122f2f2f0ba7bd36c264f03dd6201232335bdcb
> Cr-Commit-Position: refs/heads/master@{#429556}

TBR=anthonyvd@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=652791, 667750
Committed: https://crrev.com/b9041776b62a64c4d3de4c530c6492b8312dd447
Cr-Commit-Position: refs/heads/master@{#436251}

[msarda, 2016-12-02 12:37:23]

The CQ bit was checked by msarda@chromium.org

[msarda, 2016-12-02 12:37:23]

Created Revert of Use the modal view when signing in from chrome.identity
extension API.

[commit-bot: I haz the power, 2016-12-02 12:37:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 13:25:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 13:25:57]

Failed to apply patch for chrome/browser/ui/webui/signin/login_ui_service.cc:
While running git apply --index -p1;
  error: patch failed: chrome/browser/ui/webui/signin/login_ui_service.cc:10
  error: chrome/browser/ui/webui/signin/login_ui_service.cc: patch does not
apply

Patch:       chrome/browser/ui/webui/signin/login_ui_service.cc
Index: chrome/browser/ui/webui/signin/login_ui_service.cc
diff --git a/chrome/browser/ui/webui/signin/login_ui_service.cc
b/chrome/browser/ui/webui/signin/login_ui_service.cc
index
9250df6b405dab3bd918e3d1a5251356c508aea7..8fe5bf989ff93035c6a9e8ea74e075a56ab17419
100644
--- a/chrome/browser/ui/webui/signin/login_ui_service.cc
+++ b/chrome/browser/ui/webui/signin/login_ui_service.cc
@@ -10,7 +10,6 @@
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_window.h"
 #include "chrome/browser/ui/chrome_pages.h"
-#include "chrome/browser/ui/profile_chooser_constants.h"
 #include "chrome/browser/ui/scoped_tabbed_browser_displayer.h"
 #include "chrome/browser/ui/webui/signin/login_ui_service_factory.h"
 #include "chrome/common/url_constants.h"
@@ -58,15 +57,9 @@
   NOTREACHED();
 #else
   chrome::ScopedTabbedBrowserDisplayer displayer(profile_);
-  profiles::BubbleViewMode signin_mode =
profiles::BUBBLE_VIEW_MODE_GAIA_SIGNIN;
-  if (SigninViewController::ShouldShowModalSigninForMode(signin_mode)) {
-    displayer.browser()->ShowModalSigninWindow(signin_mode,
-        signin_metrics::AccessPoint::ACCESS_POINT_EXTENSIONS);
-  } else {
-    chrome::ShowBrowserSignin(
-        displayer.browser(),
-        signin_metrics::AccessPoint::ACCESS_POINT_EXTENSIONS);
-  }
+  chrome::ShowBrowserSignin(
+      displayer.browser(),
+      signin_metrics::AccessPoint::ACCESS_POINT_EXTENSIONS);
 #endif
 }

[msarda, 2016-12-05 09:13:37]

Description was changed from

==========
Revert of Use the modal view when signing in from chrome.identity extension API.
(patchset #2 id:10001 of https://codereview.chromium.org/2462603002/ )

Reason for revert:
This CL as it is responsible for crash
https://bugs.chromium.org/p/chromium/issues/detail?id=667750

Original issue's description:
> Use the modal view when signing in from chrome.identity extension API.
> 
> BUG=652791
> 
> Committed: https://crrev.com/8122f2f2f0ba7bd36c264f03dd6201232335bdcb
> Cr-Commit-Position: refs/heads/master@{#429556}

TBR=anthonyvd@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=652791
==========

to

==========
Revert of Use the modal view when signing in from chrome.identity extension API.
(patchset #2 id:10001 of https://codereview.chromium.org/2462603002/ )

Reason for revert:
This CL as it is responsible for crash
https://bugs.chromium.org/p/chromium/issues/detail?id=667750

Original issue's description:
> Use the modal view when signing in from chrome.identity extension API.
> 
> BUG=652791
> 
> Committed: https://crrev.com/8122f2f2f0ba7bd36c264f03dd6201232335bdcb
> Cr-Commit-Position: refs/heads/master@{#429556}

TBR=anthonyvd@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=652791, 667750
==========

[msarda, 2016-12-05 09:13:53]

The CQ bit was checked by msarda@chromium.org

[commit-bot: I haz the power, 2016-12-05 09:14:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-05 10:02:37]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480929233810230,
"parent_rev": "c24cbfbca12fe786cb0419209174032fd2fcc630", "commit_rev":
"21919f2a7ccfa321b102acfafb4255e3da0f39af"}

[commit-bot: I haz the power, 2016-12-05 10:03:01]

Description was changed from

==========
Revert of Use the modal view when signing in from chrome.identity extension API.
(patchset #2 id:10001 of https://codereview.chromium.org/2462603002/ )

Reason for revert:
This CL as it is responsible for crash
https://bugs.chromium.org/p/chromium/issues/detail?id=667750

Original issue's description:
> Use the modal view when signing in from chrome.identity extension API.
> 
> BUG=652791
> 
> Committed: https://crrev.com/8122f2f2f0ba7bd36c264f03dd6201232335bdcb
> Cr-Commit-Position: refs/heads/master@{#429556}

TBR=anthonyvd@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=652791, 667750
==========

to

==========
Revert of Use the modal view when signing in from chrome.identity extension API.
(patchset #2 id:10001 of https://codereview.chromium.org/2462603002/ )

Reason for revert:
This CL as it is responsible for crash
https://bugs.chromium.org/p/chromium/issues/detail?id=667750

Original issue's description:
> Use the modal view when signing in from chrome.identity extension API.
> 
> BUG=652791
> 
> Committed: https://crrev.com/8122f2f2f0ba7bd36c264f03dd6201232335bdcb
> Cr-Commit-Position: refs/heads/master@{#429556}

TBR=anthonyvd@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=652791, 667750
==========

[commit-bot: I haz the power, 2016-12-05 10:03:02]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-12-05 10:06:43]

Description was changed from

==========
Revert of Use the modal view when signing in from chrome.identity extension API.
(patchset #2 id:10001 of https://codereview.chromium.org/2462603002/ )

Reason for revert:
This CL as it is responsible for crash
https://bugs.chromium.org/p/chromium/issues/detail?id=667750

Original issue's description:
> Use the modal view when signing in from chrome.identity extension API.
> 
> BUG=652791
> 
> Committed: https://crrev.com/8122f2f2f0ba7bd36c264f03dd6201232335bdcb
> Cr-Commit-Position: refs/heads/master@{#429556}

TBR=anthonyvd@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=652791, 667750
==========

to

==========
Revert of Use the modal view when signing in from chrome.identity extension API.
(patchset #2 id:10001 of https://codereview.chromium.org/2462603002/ )

Reason for revert:
This CL as it is responsible for crash
https://bugs.chromium.org/p/chromium/issues/detail?id=667750

Original issue's description:
> Use the modal view when signing in from chrome.identity extension API.
>
> BUG=652791
>
> Committed: https://crrev.com/8122f2f2f0ba7bd36c264f03dd6201232335bdcb
> Cr-Commit-Position: refs/heads/master@{#429556}

TBR=anthonyvd@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=652791, 667750

Committed: https://crrev.com/b9041776b62a64c4d3de4c530c6492b8312dd447
Cr-Commit-Position: refs/heads/master@{#436251}
==========

[commit-bot: I haz the power, 2016-12-05 10:06:44]

Patchset 2 (id:??) landed as
https://crrev.com/b9041776b62a64c4d3de4c530c6492b8312dd447
Cr-Commit-Position: refs/heads/master@{#436251}