Addressed haraken's feedback on the removal of WebGLObject maps.

Addressed haraken's feedback on the removal of WebGLObject maps.

BUG=537054, 666061
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/344f19bd27857cd931e41f09fd81573323ede110
Cr-Commit-Position: refs/heads/master@{#436259}

[Ken Russell (switch to Gerrit), 2016-12-05 06:33:14]

Description was changed from

==========
Addressed haraken's feedback on the removal of WebGLObject maps.

BUG=537054, 666061
==========

to

==========
Addressed haraken's feedback on the removal of WebGLObject maps.

BUG=537054, 666061
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Ken Russell (switch to Gerrit), 2016-12-05 06:33:57]

kbr@chromium.org changed reviewers:
+ haraken@chromium.org

[Ken Russell (switch to Gerrit), 2016-12-05 06:33:58]

haraken: please review. Thanks.

[haraken, 2016-12-05 06:38:55]

LGTM

[Michael Lippautz, 2016-12-05 07:41:41]

lgtm

The unwritten (people should use the TraceWrapperMember abstraction if possible)
rule of thumb is 

  For any A.x = y, where A is your class and x is a field or a some container
that should be traced and '=' is a direct write or an addition to the container,
then you need ScriptWrappableVisitor::writeBarrier(A, y). Usually you are within
some method of A, resulting in ScriptWrappableVisitor::writeBarrier(this, y).

[Michael Lippautz, 2016-12-05 07:41:45]

lgtm

The unwritten (people should use the TraceWrapperMember abstraction if possible)
rule of thumb is 

  For any A.x = y, where A is your class and x is a field or a some container
that should be traced and '=' is a direct write or an addition to the container,
then you need ScriptWrappableVisitor::writeBarrier(A, y). Usually you are within
some method of A, resulting in ScriptWrappableVisitor::writeBarrier(this, y).

[Ken Russell (switch to Gerrit), 2016-12-05 08:09:20]

On 2016/12/05 07:41:45, Michael Lippautz wrote:
> lgtm
> 
> The unwritten (people should use the TraceWrapperMember abstraction if
possible)
> rule of thumb is 
> 
>   For any A.x = y, where A is your class and x is a field or a some container
> that should be traced and '=' is a direct write or an addition to the
container,
> then you need ScriptWrappableVisitor::writeBarrier(A, y). Usually you are
within
> some method of A, resulting in ScriptWrappableVisitor::writeBarrier(this, y).

Thanks Michael. Could you add that writeup to
https://chromium.googlesource.com/chromium/src/+/master/third_party/WebKit/So...
?

[Ken Russell (switch to Gerrit), 2016-12-05 10:00:11]

The CQ bit was checked by kbr@chromium.org

[Ken Russell (switch to Gerrit), 2016-12-05 10:00:12]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, mlippautz@chromium.org
Link to the patchset: https://codereview.chromium.org/2548273002/#ps20001
(title: "Rebased.")

[commit-bot: I haz the power, 2016-12-05 10:00:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-05 11:15:03]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480932011926420,
"parent_rev": "b83a10f8ee5a1d6c94aadba949d3c5a9b6ff9c45", "commit_rev":
"10b2d4c765749c5d90ec6ce89e1951172052accb"}

[commit-bot: I haz the power, 2016-12-05 11:15:31]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-05 11:17:12]

Description was changed from

==========
Addressed haraken's feedback on the removal of WebGLObject maps.

BUG=537054, 666061
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Addressed haraken's feedback on the removal of WebGLObject maps.

BUG=537054, 666061
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/344f19bd27857cd931e41f09fd81573323ede110
Cr-Commit-Position: refs/heads/master@{#436259}
==========

[commit-bot: I haz the power, 2016-12-05 11:17:13]

Patchset 2 (id:??) landed as
https://crrev.com/344f19bd27857cd931e41f09fd81573323ede110
Cr-Commit-Position: refs/heads/master@{#436259}