Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 2548273002: Addressed haraken's feedback on the removal of WebGLObject maps. (Closed)

Created:
4 years ago by Ken Russell (switch to Gerrit)
Modified:
4 years ago
CC:
chromium-reviews, blink-reviews, Zhenyao Mo, Kai Ninomiya, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Addressed haraken's feedback on the removal of WebGLObject maps. BUG=537054, 666061 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/344f19bd27857cd931e41f09fd81573323ede110 Cr-Commit-Position: refs/heads/master@{#436259}

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/modules/webgl/WebGLContextGroup.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLObject.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLSharedObject.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
Ken Russell (switch to Gerrit)
haraken: please review. Thanks.
4 years ago (2016-12-05 06:33:58 UTC) #3
haraken
LGTM
4 years ago (2016-12-05 06:38:55 UTC) #4
Michael Lippautz
lgtm The unwritten (people should use the TraceWrapperMember abstraction if possible) rule of thumb is ...
4 years ago (2016-12-05 07:41:41 UTC) #5
Michael Lippautz
lgtm The unwritten (people should use the TraceWrapperMember abstraction if possible) rule of thumb is ...
4 years ago (2016-12-05 07:41:45 UTC) #6
Ken Russell (switch to Gerrit)
On 2016/12/05 07:41:45, Michael Lippautz wrote: > lgtm > > The unwritten (people should use ...
4 years ago (2016-12-05 08:09:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2548273002/20001
4 years ago (2016-12-05 10:00:33 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-05 11:15:31 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-05 11:17:13 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/344f19bd27857cd931e41f09fd81573323ede110
Cr-Commit-Position: refs/heads/master@{#436259}

Powered by Google App Engine
This is Rietveld 408576698