[DevTools] Migrate dom, emulation, inspector, network, page and schema handlers to new generator.

[DevTools] Migrate dom, emulation, inspector, network, page and schema handlers to new generator.

This also includes DevToolsSession::Dispatch utility method
which offers message to DevToolsManagerDelegate.

BUG=664683
TBR=pfeldman

Committed: https://crrev.com/b4f43e447c1bb2d8e255395aa13a0eaf88a516ad
Cr-Commit-Position: refs/heads/master@{#438078}

[dgozman, 2016-12-05 23:32:52]

Description was changed from

==========
[DevTools] Migrate schema and network handlers to new generator.

This also includes DevToolsSession::Dispatch utility method
which offers message to DevToolsManagerDelegate.

BUG=664683
==========

to

==========
[DevTools] Migrate inspector, network and schema handlers to new generator.

This also includes DevToolsSession::Dispatch utility method
which offers message to DevToolsManagerDelegate.

BUG=664683
==========

[dgozman, 2016-12-06 01:37:10]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[dgozman, 2016-12-06 01:37:22]

dgozman@chromium.org changed reviewers:
+ caseq@chromium.org

[dgozman, 2016-12-06 01:37:23]

Take a look please.

[commit-bot: I haz the power, 2016-12-06 01:37:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 02:30:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-06 02:30:58]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[caseq, 2016-12-06 18:42:13]

lgtm

https://codereview.chromium.org/2548263002/diff/20001/content/browser/devtool...
File content/browser/devtools/browser_devtools_agent_host.cc (right):

https://codereview.chromium.org/2548263002/diff/20001/content/browser/devtool...
content/browser/devtools/browser_devtools_agent_host.cc:61:
io_handler_->Disable();
Here and below, let's get this done in destructor.

https://codereview.chromium.org/2548263002/diff/20001/content/browser/devtool...
File content/browser/devtools/render_frame_devtools_agent_host.cc (right):

https://codereview.chromium.org/2548263002/diff/20001/content/browser/devtool...
content/browser/devtools/render_frame_devtools_agent_host.cc:381: return
!!agent_host && agent_host->network_handler_ &&
nit: nuke !!

https://codereview.chromium.org/2548263002/diff/20001/content/browser/devtool...
content/browser/devtools/render_frame_devtools_agent_host.cc:494:
inspector_handler_->Wire(session()->dispatcher());
Symmetrically to detaching automatically in destructor, let's move wiring into
the constructor -- it looks like a handler never exists in a detached state
practically, so why not get this explicit.

[dgozman, 2016-12-07 00:22:13]

https://codereview.chromium.org/2548263002/diff/20001/content/browser/devtool...
File content/browser/devtools/render_frame_devtools_agent_host.cc (right):

https://codereview.chromium.org/2548263002/diff/20001/content/browser/devtool...
content/browser/devtools/render_frame_devtools_agent_host.cc:381: return
!!agent_host && agent_host->network_handler_ &&
On 2016/12/06 18:42:13, caseq wrote:
> nit: nuke !!

Done.

https://codereview.chromium.org/2548263002/diff/20001/content/browser/devtool...
content/browser/devtools/render_frame_devtools_agent_host.cc:494:
inspector_handler_->Wire(session()->dispatcher());
On 2016/12/06 18:42:13, caseq wrote:
> Symmetrically to detaching automatically in destructor, let's move wiring into
> the constructor -- it looks like a handler never exists in a detached state
> practically, so why not get this explicit.

Good point. I'll follow up with a refactoring after migration of all domains.

[dgozman, 2016-12-07 00:22:22]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-07 00:23:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 01:23:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 01:23:22]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[dgozman, 2016-12-08 01:24:14]

Description was changed from

==========
[DevTools] Migrate inspector, network and schema handlers to new generator.

This also includes DevToolsSession::Dispatch utility method
which offers message to DevToolsManagerDelegate.

BUG=664683
==========

to

==========
[DevTools] Migrate dom, emulation, inspector, network, page and schema handlers
to new generator.

This also includes DevToolsSession::Dispatch utility method
which offers message to DevToolsManagerDelegate.

BUG=664683
==========

[dgozman, 2016-12-08 01:26:29]

Please take a look at tests, generator and new domains.

[dgozman, 2016-12-08 01:27:10]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 01:28:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 03:10:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 03:10:58]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[dgozman, 2016-12-09 00:11:37]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-09 00:12:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 00:22:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-09 00:22:22]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[caseq, 2016-12-09 01:57:50]

lgtm

https://codereview.chromium.org/2548263002/diff/100001/third_party/inspector_...
File third_party/inspector_protocol/lib/DispatcherBase_cpp.template (right):

https://codereview.chromium.org/2548263002/diff/100001/third_party/inspector_...
third_party/inspector_protocol/lib/DispatcherBase_cpp.template:253: for (const
auto& pair : redirects)
nit: do we really need to clone it?

https://codereview.chromium.org/2548263002/diff/100001/third_party/inspector_...
third_party/inspector_protocol/lib/DispatcherBase_cpp.template:289: if
(m_redirects.find(method) != m_redirects.end())
nit: keep the iterator returned from find to avoid second lookup

[dgozman, 2016-12-12 22:53:13]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-12 22:55:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dgozman, 2016-12-12 23:01:25]

Thank you for review!

https://codereview.chromium.org/2548263002/diff/100001/third_party/inspector_...
File third_party/inspector_protocol/lib/DispatcherBase_cpp.template (right):

https://codereview.chromium.org/2548263002/diff/100001/third_party/inspector_...
third_party/inspector_protocol/lib/DispatcherBase_cpp.template:253: for (const
auto& pair : redirects)
On 2016/12/09 01:57:49, caseq wrote:
> nit: do we really need to clone it?

Yes, this accumulates them in UberDispatcher.

https://codereview.chromium.org/2548263002/diff/100001/third_party/inspector_...
third_party/inspector_protocol/lib/DispatcherBase_cpp.template:289: if
(m_redirects.find(method) != m_redirects.end())
On 2016/12/09 01:57:49, caseq wrote:
> nit: keep the iterator returned from find to avoid second lookup

Done.

[dgozman, 2016-12-13 04:09:53]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2016-12-13 04:09:53]

The patchset sent to the CQ was uploaded after l-g-t-m from caseq@chromium.org
Link to the patchset: https://codereview.chromium.org/2548263002/#ps120001
(title: "rebased atop of roll")

[commit-bot: I haz the power, 2016-12-13 04:10:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 04:18:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 04:18:18]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[dgozman, 2016-12-13 04:56:38]

Description was changed from

==========
[DevTools] Migrate dom, emulation, inspector, network, page and schema handlers
to new generator.

This also includes DevToolsSession::Dispatch utility method
which offers message to DevToolsManagerDelegate.

BUG=664683
==========

to

==========
[DevTools] Migrate dom, emulation, inspector, network, page and schema handlers
to new generator.

This also includes DevToolsSession::Dispatch utility method
which offers message to DevToolsManagerDelegate.

BUG=664683
TBR=pfeldman
==========

[dgozman, 2016-12-13 04:57:00]

TBR'ing pfeldman for BUILD.gn

[dgozman, 2016-12-13 04:57:10]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2016-12-13 04:57:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 06:12:50]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1481605030590020,
"parent_rev": "5993e981f3d37186b4d01e08720eceb0036d3ab4", "commit_rev":
"17677eb17c1d2aaa4d120d1310c2664672b5aaaf"}

[commit-bot: I haz the power, 2016-12-13 06:14:02]

Description was changed from

==========
[DevTools] Migrate dom, emulation, inspector, network, page and schema handlers
to new generator.

This also includes DevToolsSession::Dispatch utility method
which offers message to DevToolsManagerDelegate.

BUG=664683
TBR=pfeldman
==========

to

==========
[DevTools] Migrate dom, emulation, inspector, network, page and schema handlers
to new generator.

This also includes DevToolsSession::Dispatch utility method
which offers message to DevToolsManagerDelegate.

BUG=664683
TBR=pfeldman

Review-Url: https://codereview.chromium.org/2548263002
==========

[commit-bot: I haz the power, 2016-12-13 06:14:03]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-12-13 06:17:34]

Description was changed from

==========
[DevTools] Migrate dom, emulation, inspector, network, page and schema handlers
to new generator.

This also includes DevToolsSession::Dispatch utility method
which offers message to DevToolsManagerDelegate.

BUG=664683
TBR=pfeldman

Review-Url: https://codereview.chromium.org/2548263002
==========

to

==========
[DevTools] Migrate dom, emulation, inspector, network, page and schema handlers
to new generator.

This also includes DevToolsSession::Dispatch utility method
which offers message to DevToolsManagerDelegate.

BUG=664683
TBR=pfeldman

Committed: https://crrev.com/b4f43e447c1bb2d8e255395aa13a0eaf88a516ad
Cr-Commit-Position: refs/heads/master@{#438078}
==========

[commit-bot: I haz the power, 2016-12-13 06:17:35]

Patchset 7 (id:??) landed as
https://crrev.com/b4f43e447c1bb2d8e255395aa13a0eaf88a516ad
Cr-Commit-Position: refs/heads/master@{#438078}