Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2548253002:
Do not log FirstMeaningfulPaint status if page load aborted before first paint (Closed)
|
Created:
4 years ago by Kunihiko Sakamoto Modified:
4 years ago CC:
chromium-reviews, csharrison+watch_chromium.org, loading-reviews+metrics_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDo not log FirstMeaningfulPaint status if page load aborted before first paint
FirstMeaningfulPaintSignalStatus UMA from canary channel indicates that
about 32% of page loads did not reach network stable. However,
FirstMeaningfulPaintStatus histogram says it is 22%, probably because
the latter is logged only for page loads that had first paint.
This patch replaces FirstMeaningfulPaintSignalStatus with
FirstMeaningfulPaintSignalStatus2, which ignores page loads without
first paint.
BUG=632081
Committed: https://crrev.com/96e6c826a5129e71b7dcce2c8f137f47ed4d739f
Cr-Commit-Position: refs/heads/master@{#436804}
Patch Set 1 #Patch Set 2 : version bump #
Messages
Total messages: 26 (18 generated)
Patchset #1 (id:1) has been deleted
The CQ bit was checked by ksakamoto@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Do not log FirstMeaningfulPaint status if page load aborted before first paint BUG=632081 ========== to ========== Do not log FirstMeaningfulPaint status if page load aborted before first paint FirstMeaningfulPaintSignalStatus UMA from canary channel indicates that about 32% of page loads did not reach network stable. However, FirstMeaningfulPaintStatus histogram says it is 22%, probably because the latter is logged only for page loads that had first paint. This patch makes FirstMeaningfulPaintSignalStatus ignore page loads without first paint. BUG=632081 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Do not log FirstMeaningfulPaint status if page load aborted before first paint FirstMeaningfulPaintSignalStatus UMA from canary channel indicates that about 32% of page loads did not reach network stable. However, FirstMeaningfulPaintStatus histogram says it is 22%, probably because the latter is logged only for page loads that had first paint. This patch makes FirstMeaningfulPaintSignalStatus ignore page loads without first paint. BUG=632081 ========== to ========== Do not log FirstMeaningfulPaint status if page load aborted before first paint FirstMeaningfulPaintSignalStatus UMA from canary channel indicates that about 32% of page loads did not reach network stable. However, FirstMeaningfulPaintStatus histogram says it is 22%, probably because the latter is logged only for page loads that had first paint. This patch makes FirstMeaningfulPaintSignalStatus match FirstMeaningfulPaintStatus, by ignoring page loads without first paint. BUG=632081 ==========
ksakamoto@chromium.org changed reviewers: + bmcquade@chromium.org, csharrison@chromium.org
Generally LG, but a major change to the metric like this usually warrants a version bump to make analysis easier.
Description was changed from ========== Do not log FirstMeaningfulPaint status if page load aborted before first paint FirstMeaningfulPaintSignalStatus UMA from canary channel indicates that about 32% of page loads did not reach network stable. However, FirstMeaningfulPaintStatus histogram says it is 22%, probably because the latter is logged only for page loads that had first paint. This patch makes FirstMeaningfulPaintSignalStatus match FirstMeaningfulPaintStatus, by ignoring page loads without first paint. BUG=632081 ========== to ========== Do not log FirstMeaningfulPaint status if page load aborted before first paint FirstMeaningfulPaintSignalStatus UMA from canary channel indicates that about 32% of page loads did not reach network stable. However, FirstMeaningfulPaintStatus histogram says it is 22%, probably because the latter is logged only for page loads that had first paint. This patch replaces FirstMeaningfulPaintSignalStatus with FirstMeaningfulPaintSignalStatus2, which ignores page loads without first paint. BUG=632081 ==========
ksakamoto@chromium.org changed reviewers: + isherman@chromium.org
+isherman for histograms.xml On 2016/12/05 15:43:46, Charlie Harrison wrote: > Generally LG, but a major change to the metric like this usually warrants a > version bump to make analysis easier. Done.
LGTM
Metrics LGTM, thanks.
The CQ bit was checked by isherman@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by ksakamoto@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481069483806120,
"parent_rev": "0b977b9804ae26f6353d3cc0a48e578eacbe29ca", "commit_rev":
"e785d0bac9cd21976fe80352847040e1bc8a3586"}
Message was sent while issue was closed.
Description was changed from ========== Do not log FirstMeaningfulPaint status if page load aborted before first paint FirstMeaningfulPaintSignalStatus UMA from canary channel indicates that about 32% of page loads did not reach network stable. However, FirstMeaningfulPaintStatus histogram says it is 22%, probably because the latter is logged only for page loads that had first paint. This patch replaces FirstMeaningfulPaintSignalStatus with FirstMeaningfulPaintSignalStatus2, which ignores page loads without first paint. BUG=632081 ========== to ========== Do not log FirstMeaningfulPaint status if page load aborted before first paint FirstMeaningfulPaintSignalStatus UMA from canary channel indicates that about 32% of page loads did not reach network stable. However, FirstMeaningfulPaintStatus histogram says it is 22%, probably because the latter is logged only for page loads that had first paint. This patch replaces FirstMeaningfulPaintSignalStatus with FirstMeaningfulPaintSignalStatus2, which ignores page loads without first paint. BUG=632081 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Do not log FirstMeaningfulPaint status if page load aborted before first paint FirstMeaningfulPaintSignalStatus UMA from canary channel indicates that about 32% of page loads did not reach network stable. However, FirstMeaningfulPaintStatus histogram says it is 22%, probably because the latter is logged only for page loads that had first paint. This patch replaces FirstMeaningfulPaintSignalStatus with FirstMeaningfulPaintSignalStatus2, which ignores page loads without first paint. BUG=632081 ========== to ========== Do not log FirstMeaningfulPaint status if page load aborted before first paint FirstMeaningfulPaintSignalStatus UMA from canary channel indicates that about 32% of page loads did not reach network stable. However, FirstMeaningfulPaintStatus histogram says it is 22%, probably because the latter is logged only for page loads that had first paint. This patch replaces FirstMeaningfulPaintSignalStatus with FirstMeaningfulPaintSignalStatus2, which ignores page loads without first paint. BUG=632081 Committed: https://crrev.com/96e6c826a5129e71b7dcce2c8f137f47ed4d739f Cr-Commit-Position: refs/heads/master@{#436804} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/96e6c826a5129e71b7dcce2c8f137f47ed4d739f Cr-Commit-Position: refs/heads/master@{#436804} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
