Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Unified Diff: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc

Issue 2548253002: Do not log FirstMeaningfulPaint status if page load aborted before first paint (Closed)
Patch Set: version bump Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
diff --git a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
index f7333bed0aba9fe5a2af9a75e979f3b7b9bed805..79531b63b93b3795f5efb9b7c05d23bcd1a06056 100644
--- a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
+++ b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
@@ -195,8 +195,8 @@ const char kHistogramFirstContentfulPaintUserInitiated[] =
const char kHistogramFirstMeaningfulPaintStatus[] =
"PageLoad.Experimental.PaintTiming.FirstMeaningfulPaintStatus";
-const char kHistogramFirstMeaningfulPaintSignalStatus[] =
- "PageLoad.Experimental.PaintTiming.FirstMeaningfulPaintSignalStatus";
+const char kHistogramFirstMeaningfulPaintSignalStatus2[] =
+ "PageLoad.Experimental.PaintTiming.FirstMeaningfulPaintSignalStatus2";
const char kHistogramFirstNonScrollInputAfterFirstPaint[] =
"PageLoad.InputTiming.NavigationToFirstNonScroll.AfterPaint";
@@ -582,18 +582,20 @@ void CorePageLoadMetricsObserver::RecordTimingHistograms(
internal::FIRST_MEANINGFUL_PAINT_DID_NOT_REACH_FIRST_CONTENTFUL_PAINT);
}
- enum FirstMeaningfulPaintSignalStatus {
- HAD_USER_INPUT = 1 << 0,
- NETWORK_STABLE = 1 << 1,
- FIRST_MEANINGFUL_PAINT_SIGNAL_STATUS_LAST_ENTRY = 1 << 2
- };
- int signal_status =
- (first_user_interaction_after_first_paint_.is_null() ?
- 0 : HAD_USER_INPUT) +
- (timing.first_meaningful_paint ? NETWORK_STABLE : 0);
- UMA_HISTOGRAM_ENUMERATION(
- internal::kHistogramFirstMeaningfulPaintSignalStatus,
- signal_status, FIRST_MEANINGFUL_PAINT_SIGNAL_STATUS_LAST_ENTRY);
+ if (timing.first_paint) {
+ enum FirstMeaningfulPaintSignalStatus {
+ HAD_USER_INPUT = 1 << 0,
+ NETWORK_STABLE = 1 << 1,
+ FIRST_MEANINGFUL_PAINT_SIGNAL_STATUS_LAST_ENTRY = 1 << 2
+ };
+ int signal_status =
+ (first_user_interaction_after_first_paint_.is_null() ?
+ 0 : HAD_USER_INPUT) +
+ (timing.first_meaningful_paint ? NETWORK_STABLE : 0);
+ UMA_HISTOGRAM_ENUMERATION(
+ internal::kHistogramFirstMeaningfulPaintSignalStatus2,
+ signal_status, FIRST_MEANINGFUL_PAINT_SIGNAL_STATUS_LAST_ENTRY);
+ }
if (timing.first_meaningful_paint) {
if (first_user_interaction_after_first_paint_.is_null()) {
PAGE_LOAD_HISTOGRAM(internal::kHistogramFirstMeaningfulPaintNoUserInput,
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698