Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2067)

Issue 2548213005: Add base::time::FromJavaTime (Closed)

Created:
2 years, 10 months ago by Theresa
Modified:
2 years, 10 months ago
Reviewers:
Marc Treib
CC:
chromium-reviews, ntp-dev+reviews_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add base::time::FromJavaTime BUG=654071 TBR=miu@chromium.org,dfalcantara@chromium.org Committed: https://crrev.com/ace20e29b7faca97fae2f2136fea8cb04a12ea69 Cr-Commit-Position: refs/heads/master@{#436514}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M base/time/time.h View 1 chunk +2 lines, -1 line 0 comments Download
M base/time/time.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/android/ntp/ntp_snippets_bridge.cc View 4 chunks +3 lines, -9 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Theresa
https://codereview.chromium.org/2542203002/ is failing to land because the linux asan bot keeps timing out; the changes ...
2 years, 10 months ago (2016-12-06 02:50:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2548213005/1
2 years, 10 months ago (2016-12-06 02:53:18 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
2 years, 10 months ago (2016-12-06 03:52:24 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ace20e29b7faca97fae2f2136fea8cb04a12ea69 Cr-Commit-Position: refs/heads/master@{#436514}
2 years, 10 months ago (2016-12-06 03:54:24 UTC) #12
Marc Treib
2 years, 10 months ago (2016-12-06 09:45:57 UTC) #14
Message was sent while issue was closed.
lgtm

Yay! Thanks for fixing my TODO :)

Powered by Google App Engine
This is Rietveld 408576698