Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Issue 2542203002: [Android History] Add Android history manager UI and bridge (Closed)

Created:
4 years ago by Theresa
Modified:
4 years ago
Reviewers:
sky, miu, gone
CC:
chromium-reviews, asanka, agrieve+watch_chromium.org, browser-components-watch_chromium.org, ntp-dev+reviews_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android History] Add Android history manager UI and bridge Adds the basic scaffolding for the Android history manager UI: * Creates a JNI BrowsingHistoryBridge that serves as a conduit between the native BrowsingHistoryService and Java UI. * Creates a new Android-specific history manager UI hidden behind a command line flag. * Displays history items in history manager UI. BUG=654071 Committed: https://crrev.com/87cc36611529a2271b09989491561b3a631ef8cd Cr-Commit-Position: refs/heads/master@{#436648}

Patch Set 1 #

Patch Set 2 : Add OWNERS files #

Total comments: 30

Patch Set 3 : Changes from dfalcantara@ review #

Patch Set 4 : Change parameter declaration order #

Total comments: 2

Patch Set 5 : Rename variable #

Patch Set 6 : Rebase, drop changes to time.* #

Unified diffs Side-by-side diffs Delta from patch set Stats (+808 lines, -24 lines) Patch
M chrome/android/java/AndroidManifest.xml View 1 chunk +8 lines, -0 lines 0 comments Download
A chrome/android/java/res/drawable-hdpi/history_large.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-mdpi/history_large.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-xhdpi/history_large.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-xxhdpi/history_large.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-xxxhdpi/history_large.png View Binary file 0 comments Download
A + chrome/android/java/res/layout/date_view.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/android/java/res/layout/download_date_view.xml View 1 chunk +0 lines, -14 lines 0 comments Download
A chrome/android/java/res/layout/history_item_view.xml View 1 2 1 chunk +72 lines, -0 lines 0 comments Download
A chrome/android/java/res/layout/history_main.xml View 1 chunk +10 lines, -0 lines 0 comments Download
A chrome/android/java/res/layout/history_toolbar.xml View 1 2 1 chunk +13 lines, -0 lines 0 comments Download
A chrome/android/java/res/menu/history_manager_menu.xml View 1 chunk +35 lines, -0 lines 0 comments Download
M chrome/android/java/res/values/dimens.xml View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java View 1 2 3 4 5 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerUi.java View 1 2 3 4 5 2 chunks +4 lines, -1 line 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/history/BrowsingHistoryBridge.java View 1 2 1 chunk +60 lines, -0 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/history/HistoryActivity.java View 1 chunk +30 lines, -0 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/history/HistoryAdapter.java View 1 2 1 chunk +82 lines, -0 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/history/HistoryItem.java View 1 2 1 chunk +56 lines, -0 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/history/HistoryItemView.java View 1 chunk +43 lines, -0 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/history/HistoryManager.java View 1 2 1 chunk +79 lines, -0 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/history/HistoryManagerToolbar.java View 1 chunk +23 lines, -0 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/history/HistoryManagerUtils.java View 1 2 3 4 1 chunk +57 lines, -0 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/history/OWNERS View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/widget/selection/SelectableItemViewHolder.java View 1 chunk +34 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/widget/selection/SelectableListLayout.java View 1 2 3 4 5 2 chunks +4 lines, -7 lines 0 comments Download
M chrome/android/java/strings/android_chrome_strings.grd View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/android/java_sources.gni View 1 2 3 4 5 2 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/BUILD.gn View 1 2 3 4 5 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/android/chrome_jni_registrar.cc View 1 2 3 4 5 2 chunks +2 lines, -0 lines 0 comments Download
A chrome/browser/android/history/OWNERS View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/browser/android/history/browsing_history_bridge.h View 1 2 1 chunk +57 lines, -0 lines 0 comments Download
A chrome/browser/android/history/browsing_history_bridge.cc View 1 2 1 chunk +113 lines, -0 lines 0 comments Download
M chrome/browser/history/browsing_history_service_handler.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 45 (25 generated)
Theresa
ptal - apologies in advance for the large CL. Let me know if you see ...
4 years ago (2016-12-01 19:30:11 UTC) #4
gone
https://codereview.chromium.org/2542203002/diff/20001/chrome/android/java/res/layout/history_item_view.xml File chrome/android/java/res/layout/history_item_view.xml (right): https://codereview.chromium.org/2542203002/diff/20001/chrome/android/java/res/layout/history_item_view.xml#newcode7 chrome/android/java/res/layout/history_item_view.xml:7: <view class="org.chromium.chrome.browser.history.HistoryItemView" Could you just use the class instead ...
4 years ago (2016-12-02 19:34:37 UTC) #5
Theresa
+miu@ - ptal at time.* changes (added a FromJavaTime method) +sky@ - ptal at browsing_history_service_handler.h ...
4 years ago (2016-12-02 20:49:33 UTC) #9
gone
https://codereview.chromium.org/2542203002/diff/60001/chrome/android/java/src/org/chromium/chrome/browser/history/HistoryManagerUtils.java File chrome/android/java/src/org/chromium/chrome/browser/history/HistoryManagerUtils.java (right): https://codereview.chromium.org/2542203002/diff/60001/chrome/android/java/src/org/chromium/chrome/browser/history/HistoryManagerUtils.java#newcode21 chrome/android/java/src/org/chromium/chrome/browser/history/HistoryManagerUtils.java:21: private static final Object sLock = new Object(); nit: ...
4 years ago (2016-12-02 20:52:29 UTC) #10
sky
LGTM
4 years ago (2016-12-02 21:24:24 UTC) #11
Theresa
https://codereview.chromium.org/2542203002/diff/60001/chrome/android/java/src/org/chromium/chrome/browser/history/HistoryManagerUtils.java File chrome/android/java/src/org/chromium/chrome/browser/history/HistoryManagerUtils.java (right): https://codereview.chromium.org/2542203002/diff/60001/chrome/android/java/src/org/chromium/chrome/browser/history/HistoryManagerUtils.java#newcode21 chrome/android/java/src/org/chromium/chrome/browser/history/HistoryManagerUtils.java:21: private static final Object sLock = new Object(); On ...
4 years ago (2016-12-02 21:35:35 UTC) #14
gone
lgtm
4 years ago (2016-12-02 22:52:50 UTC) #15
miu
base/time/* changes lgtm.
4 years ago (2016-12-02 23:33:50 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2542203002/80001
4 years ago (2016-12-02 23:36:03 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/78915)
4 years ago (2016-12-03 01:12:30 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2542203002/80001
4 years ago (2016-12-05 17:43:29 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_chromium_compile_only_ng/builds/246007) linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years ago (2016-12-05 19:45:39 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2542203002/80001
4 years ago (2016-12-05 19:58:00 UTC) #29
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/273876)
4 years ago (2016-12-06 00:00:42 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2542203002/80001
4 years ago (2016-12-06 00:05:40 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2542203002/80001
4 years ago (2016-12-06 01:10:58 UTC) #36
commit-bot: I haz the power
Failed to apply patch for chrome/android/java/strings/android_chrome_strings.grd: While running git apply --index -p1; error: patch failed: ...
4 years ago (2016-12-06 02:40:51 UTC) #38
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2542203002/100001
4 years ago (2016-12-06 17:00:33 UTC) #41
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years ago (2016-12-06 18:15:36 UTC) #43
commit-bot: I haz the power
4 years ago (2016-12-06 18:18:06 UTC) #45
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/87cc36611529a2271b09989491561b3a631ef8cd
Cr-Commit-Position: refs/heads/master@{#436648}

Powered by Google App Engine
This is Rietveld 408576698