Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Unified Diff: ash/common/devtools/ash_devtools_css_agent.h

Issue 2548103002: Make bounds editable through the CSS sidepanel (Closed)
Patch Set: Make bounds editable through the CSS sidepanel Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/common/devtools/ash_devtools_css_agent.h
diff --git a/ash/common/devtools/ash_devtools_css_agent.h b/ash/common/devtools/ash_devtools_css_agent.h
index 342f21071ac575ee4bd020c42cb147fceee2f66d..c01ba28e7781c6cb90826ccf7fd4a263b2554429 100644
--- a/ash/common/devtools/ash_devtools_css_agent.h
+++ b/ash/common/devtools/ash_devtools_css_agent.h
@@ -17,7 +17,9 @@ class ASH_EXPORT AshDevToolsCSSAgent
ui::devtools::protocol::CSS::Metainfo>),
public AshDevToolsDOMAgentObserver {
public:
- explicit AshDevToolsCSSAgent(AshDevToolsDOMAgent* dom_agent);
+ explicit AshDevToolsCSSAgent(
+ AshDevToolsDOMAgent* dom_agent,
+ scoped_refptr<base::SingleThreadTaskRunner> main_thread_task_runner);
~AshDevToolsCSSAgent() override;
// CSS::Backend
@@ -27,6 +29,12 @@ class ASH_EXPORT AshDevToolsCSSAgent
int node_id,
ui::devtools::protocol::Maybe<ui::devtools::protocol::CSS::CSSStyle>*
inline_style) override;
+ ui::devtools::protocol::Response setStyleTexts(
+ std::unique_ptr<ui::devtools::protocol::Array<
+ ui::devtools::protocol::CSS::StyleDeclarationEdit>> edits,
+ std::unique_ptr<
+ ui::devtools::protocol::Array<ui::devtools::protocol::CSS::CSSStyle>>*
+ result) override;
// AshDevToolsDOMAgentObserver
void OnWindowBoundsChanged(WmWindow* window) override;
@@ -37,7 +45,10 @@ class ASH_EXPORT AshDevToolsCSSAgent
std::unique_ptr<ui::devtools::protocol::CSS::CSSStyle> GetStylesForNode(
int node_id);
void InvalidateStyleSheet(int node_id);
+ bool GetBoundsForNodeId(int node_id, gfx::Rect& bounds);
sadrul 2016/12/06 20:56:30 Make this a gfx::Rect* The styleguide requires th
Sarmad Hashmi 2016/12/07 01:23:27 Done.
+ void UpdateBounds(int node_id, const gfx::Rect& bounds);
+ scoped_refptr<base::SingleThreadTaskRunner> main_thread_task_runner_;
AshDevToolsDOMAgent* dom_agent_;
DISALLOW_COPY_AND_ASSIGN(AshDevToolsCSSAgent);
« no previous file with comments | « no previous file | ash/common/devtools/ash_devtools_css_agent.cc » ('j') | ash/common/devtools/ash_devtools_css_agent.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698