Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Side by Side Diff: ash/common/devtools/ash_devtools_css_agent.h

Issue 2548103002: Make bounds editable through the CSS sidepanel (Closed)
Patch Set: Make bounds editable through the CSS sidepanel Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef ASH_COMMON_DEVTOOLS_ASH_DEVTOOLS_CSS_AGENT_H_ 5 #ifndef ASH_COMMON_DEVTOOLS_ASH_DEVTOOLS_CSS_AGENT_H_
6 #define ASH_COMMON_DEVTOOLS_ASH_DEVTOOLS_CSS_AGENT_H_ 6 #define ASH_COMMON_DEVTOOLS_ASH_DEVTOOLS_CSS_AGENT_H_
7 7
8 #include "ash/common/devtools/ash_devtools_dom_agent.h" 8 #include "ash/common/devtools/ash_devtools_dom_agent.h"
9 #include "components/ui_devtools/CSS.h" 9 #include "components/ui_devtools/CSS.h"
10 #include "ui/views/widget/widget_observer.h" 10 #include "ui/views/widget/widget_observer.h"
11 11
12 namespace ash { 12 namespace ash {
13 namespace devtools { 13 namespace devtools {
14 14
15 class ASH_EXPORT AshDevToolsCSSAgent 15 class ASH_EXPORT AshDevToolsCSSAgent
16 : public NON_EXPORTED_BASE(ui::devtools::UiDevToolsBaseAgent< 16 : public NON_EXPORTED_BASE(ui::devtools::UiDevToolsBaseAgent<
17 ui::devtools::protocol::CSS::Metainfo>), 17 ui::devtools::protocol::CSS::Metainfo>),
18 public AshDevToolsDOMAgentObserver { 18 public AshDevToolsDOMAgentObserver {
19 public: 19 public:
20 explicit AshDevToolsCSSAgent(AshDevToolsDOMAgent* dom_agent); 20 explicit AshDevToolsCSSAgent(
21 AshDevToolsDOMAgent* dom_agent,
22 scoped_refptr<base::SingleThreadTaskRunner> main_thread_task_runner);
21 ~AshDevToolsCSSAgent() override; 23 ~AshDevToolsCSSAgent() override;
22 24
23 // CSS::Backend 25 // CSS::Backend
24 ui::devtools::protocol::Response enable() override; 26 ui::devtools::protocol::Response enable() override;
25 ui::devtools::protocol::Response disable() override; 27 ui::devtools::protocol::Response disable() override;
26 ui::devtools::protocol::Response getMatchedStylesForNode( 28 ui::devtools::protocol::Response getMatchedStylesForNode(
27 int node_id, 29 int node_id,
28 ui::devtools::protocol::Maybe<ui::devtools::protocol::CSS::CSSStyle>* 30 ui::devtools::protocol::Maybe<ui::devtools::protocol::CSS::CSSStyle>*
29 inline_style) override; 31 inline_style) override;
32 ui::devtools::protocol::Response setStyleTexts(
33 std::unique_ptr<ui::devtools::protocol::Array<
34 ui::devtools::protocol::CSS::StyleDeclarationEdit>> edits,
35 std::unique_ptr<
36 ui::devtools::protocol::Array<ui::devtools::protocol::CSS::CSSStyle>>*
37 result) override;
30 38
31 // AshDevToolsDOMAgentObserver 39 // AshDevToolsDOMAgentObserver
32 void OnWindowBoundsChanged(WmWindow* window) override; 40 void OnWindowBoundsChanged(WmWindow* window) override;
33 void OnWidgetBoundsChanged(views::Widget* widget) override; 41 void OnWidgetBoundsChanged(views::Widget* widget) override;
34 void OnViewBoundsChanged(views::View* view) override; 42 void OnViewBoundsChanged(views::View* view) override;
35 43
36 private: 44 private:
37 std::unique_ptr<ui::devtools::protocol::CSS::CSSStyle> GetStylesForNode( 45 std::unique_ptr<ui::devtools::protocol::CSS::CSSStyle> GetStylesForNode(
38 int node_id); 46 int node_id);
39 void InvalidateStyleSheet(int node_id); 47 void InvalidateStyleSheet(int node_id);
48 bool GetBoundsForNodeId(int node_id, gfx::Rect& bounds);
sadrul 2016/12/06 20:56:30 Make this a gfx::Rect* The styleguide requires th
Sarmad Hashmi 2016/12/07 01:23:27 Done.
49 void UpdateBounds(int node_id, const gfx::Rect& bounds);
40 50
51 scoped_refptr<base::SingleThreadTaskRunner> main_thread_task_runner_;
41 AshDevToolsDOMAgent* dom_agent_; 52 AshDevToolsDOMAgent* dom_agent_;
42 53
43 DISALLOW_COPY_AND_ASSIGN(AshDevToolsCSSAgent); 54 DISALLOW_COPY_AND_ASSIGN(AshDevToolsCSSAgent);
44 }; 55 };
45 56
46 } // namespace devtools 57 } // namespace devtools
47 } // namespace ash 58 } // namespace ash
48 59
49 #endif // ASH_COMMON_DEVTOOLS_ASH_DEVTOOLS_CSS_AGENT_H_ 60 #endif // ASH_COMMON_DEVTOOLS_ASH_DEVTOOLS_CSS_AGENT_H_
OLDNEW
« no previous file with comments | « no previous file | ash/common/devtools/ash_devtools_css_agent.cc » ('j') | ash/common/devtools/ash_devtools_css_agent.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698