Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(820)

Issue 254803012: Reland "Implement async touchmove dispatch during scroll" (Closed)

Created:
6 years, 7 months ago by jdduke (slow)
Modified:
6 years, 7 months ago
Reviewers:
CC:
chromium-reviews, jam, jdduke+watch_chromium.org, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Reland "Implement async touchmove dispatch during scroll" The patch landed originally in r266470, but was reverted in r266579 due to an uninitialized variable. The fix was reviewed in crrev.com/253813003. This implements a touch dispatch model in which touchmove sending is throttled while a scroll sequence is active and being consumed. Such touchmove's are marked with |cancelable = false|, indicating to any potential consumers that the event cannot be prevented from triggering a platform gesture. Throttling limits the touchmove sending rate during scrolling to 1 event per 200ms. BUG=346693, 367692 NOTRY=true TBR=jochen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266585

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+563 lines, -284 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/input/input_router_impl.cc View 4 chunks +9 lines, -15 lines 0 comments Download
M content/browser/renderer_host/input/input_router_impl_unittest.cc View 14 chunks +47 lines, -51 lines 0 comments Download
M content/browser/renderer_host/input/touch_event_queue.h View 5 chunks +41 lines, -19 lines 0 comments Download
M content/browser/renderer_host/input/touch_event_queue.cc View 16 chunks +204 lines, -83 lines 0 comments Download
M content/browser/renderer_host/input/touch_event_queue_unittest.cc View 7 chunks +234 lines, -21 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_unittest.cc View 28 chunks +0 lines, -70 lines 0 comments Download
M content/common/input/web_input_event_traits.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/input/web_input_event_traits.cc View 1 chunk +17 lines, -14 lines 0 comments Download
M content/public/common/content_switches.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/input/input_event_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_widget.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
jdduke (slow)
The CQ bit was checked by jdduke@chromium.org
6 years, 7 months ago (2014-04-28 16:06:27 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/254803012/1
6 years, 7 months ago (2014-04-28 16:06:54 UTC) #2
commit-bot: I haz the power
6 years, 7 months ago (2014-04-28 16:15:54 UTC) #3
Message was sent while issue was closed.
Change committed as 266585

Powered by Google App Engine
This is Rietveld 408576698