Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2547933003:
Stop searching for overhanging floats when the sibling's floats no longer overlap (Closed)
|
Created:
4 years ago by rhogan Modified:
4 years ago Reviewers:
pdr. CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1 Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionStop searching for overhanging floats when the sibling's floats no longer overlap
BUG=670325
Committed: https://crrev.com/eb8f963f9a5030c0007500620eefaad7c2c2c490
Cr-Commit-Position: refs/heads/master@{#436202}
Patch Set 1 #Patch Set 2 : bug 670325 #Messages
Total messages: 18 (13 generated)
The CQ bit was checked by robhogan@gmail.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by robhogan@gmail.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
robhogan@gmail.com changed reviewers: + pdr@chromium.org
Hi pdr - can you take a look? I forgot to bail early when refactoring!
Description was changed from ========== Stop searching for overhanging floats when we hit a sibling with none BUG=670325 ========== to ========== Stop searching for overhanging floats when the sibling's floats no longer overlap BUG=670325 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2016/12/03 at 11:31:57, robhogan wrote: > Hi pdr - can you take a look? I forgot to bail early when refactoring! Oops, kinda my fault. LGTM
The CQ bit was checked by robhogan@gmail.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480883923628300,
"parent_rev": "53a6bc33e6aefa1da555dcba5650ff88f505c0c7", "commit_rev":
"9752c3ee1eca4c97183766d664ba5bdfc1ac647a"}
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Stop searching for overhanging floats when the sibling's floats no longer overlap BUG=670325 ========== to ========== Stop searching for overhanging floats when the sibling's floats no longer overlap BUG=670325 Committed: https://crrev.com/eb8f963f9a5030c0007500620eefaad7c2c2c490 Cr-Commit-Position: refs/heads/master@{#436202} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/eb8f963f9a5030c0007500620eefaad7c2c2c490 Cr-Commit-Position: refs/heads/master@{#436202} |
