Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 2547843002: Refactor setImportsController() to clarify invariants (Closed)

Created:
4 years ago by tyoshino (SeeGerritForStatus)
Modified:
4 years ago
Reviewers:
hayato
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof, tfarina, webcomponents-bugzilla_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor setImportsController() to clarify invariants R=hayato@chromium.org BUG=none Committed: https://crrev.com/0f7f5b4368f7b89c235473255aacda2984e1c415 Cr-Commit-Position: refs/heads/master@{#436245}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -8 lines) Patch
M third_party/WebKit/Source/core/dom/Document.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 2 chunks +9 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/html/imports/HTMLImportLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/imports/LinkImport.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (13 generated)
tyoshino (SeeGerritForStatus)
4 years ago (2016-12-02 08:53:39 UTC) #4
tyoshino (SeeGerritForStatus)
This clarifies that a Document's HTMLImportController's master is always the same Document to ease code ...
4 years ago (2016-12-02 08:56:07 UTC) #7
hayato
lgtm
4 years ago (2016-12-05 03:05:06 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2547843002/20001
4 years ago (2016-12-05 06:40:40 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-05 08:25:45 UTC) #17
commit-bot: I haz the power
4 years ago (2016-12-05 08:27:30 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0f7f5b4368f7b89c235473255aacda2984e1c415
Cr-Commit-Position: refs/heads/master@{#436245}

Powered by Google App Engine
This is Rietveld 408576698