third_party/WebKit/Source/core/html/imports/HTMLImportLoader.cpp - Issue 2547843002: Refactor setImportsController() to clarify invariants

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/imports/HTMLImportLoader.cpp

Issue 2547843002: Refactor setImportsController() to clarify invariants (Closed)

Patch Set: Rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/imports/HTMLImportLoader.cpp

diff --git a/third_party/WebKit/Source/core/html/imports/HTMLImportLoader.cpp b/third_party/WebKit/Source/core/html/imports/HTMLImportLoader.cpp

index 6a508f582eb542e395f4f6d9016b0109f8da9097..779287e15e4f697bb5eed086c8b5b6b2e91e2352 100644

--- a/third_party/WebKit/Source/core/html/imports/HTMLImportLoader.cpp

+++ b/third_party/WebKit/Source/core/html/imports/HTMLImportLoader.cpp

@@ -55,7 +55,7 @@ void HTMLImportLoader::dispose() {

if (m_document) {

if (m_document->parser())

m_document->parser()->removeClient(this);

- m_document->setImportsController(nullptr);

+ m_document->clearImportsController();

m_document.clear();

}

clearResource();