Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5474)

Unified Diff: chrome/browser/extensions/api/messaging/extension_message_port.h

Issue 2547753002: [Extensions] Extension Port Ids and Initialization 2.0 (Closed)
Patch Set: rkaplow Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/api/messaging/extension_message_port.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/messaging/extension_message_port.h
diff --git a/chrome/browser/extensions/api/messaging/extension_message_port.h b/chrome/browser/extensions/api/messaging/extension_message_port.h
index af122c0bacaf83fb5a07e5f4385f39cc0103c8a7..4c2ba8a831d388b8eef83f1e53961221454911e2 100644
--- a/chrome/browser/extensions/api/messaging/extension_message_port.h
+++ b/chrome/browser/extensions/api/messaging/extension_message_port.h
@@ -7,6 +7,7 @@
#include "base/macros.h"
#include "chrome/browser/extensions/api/messaging/message_service.h"
+#include "extensions/common/api/messaging/port_id.h"
class GURL;
@@ -29,14 +30,14 @@ class ExtensionMessagePort : public MessageService::MessagePort {
public:
// Create a port that is tied to frame(s) in a single tab.
ExtensionMessagePort(base::WeakPtr<MessageService> message_service,
- int port_id,
+ const PortId& port_id,
const std::string& extension_id,
content::RenderFrameHost* rfh,
bool include_child_frames);
// Create a port that is tied to all frames of an extension, possibly spanning
// multiple tabs, including the invisible background page, popups, etc.
ExtensionMessagePort(base::WeakPtr<MessageService> message_service,
- int port_id,
+ const PortId& port_id,
const std::string& extension_id,
content::RenderProcessHost* extension_process);
~ExtensionMessagePort() override;
@@ -85,7 +86,7 @@ class ExtensionMessagePort : public MessageService::MessagePort {
base::WeakPtr<MessageService> weak_message_service_;
- int port_id_;
+ const PortId port_id_;
std::string extension_id_;
content::BrowserContext* browser_context_;
// Only for receivers in an extension process.
« no previous file with comments | « no previous file | chrome/browser/extensions/api/messaging/extension_message_port.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698