chrome/browser/extensions/api/messaging/extension_message_port.cc - Issue 2547753002: [Extensions] Extension Port Ids and Initialization 2.0

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/messaging/extension_message_port.cc

Issue 2547753002: [Extensions] Extension Port Ids and Initialization 2.0 (Closed)

Patch Set: rkaplow Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/messaging/extension_message_port.cc

diff --git a/chrome/browser/extensions/api/messaging/extension_message_port.cc b/chrome/browser/extensions/api/messaging/extension_message_port.cc

index caf0f068ed47e1aea9300bdcbc86daa0b8cf9db2..09e55602fe56c223209757453a0c56cbc99d8fde 100644

--- a/chrome/browser/extensions/api/messaging/extension_message_port.cc

+++ b/chrome/browser/extensions/api/messaging/extension_message_port.cc

@@ -91,7 +91,7 @@ class ExtensionMessagePort::FrameTracker : public content::WebContentsObserver,

ExtensionMessagePort::ExtensionMessagePort(

base::WeakPtr<MessageService> message_service,

- int port_id,

+ const PortId& port_id,

const std::string& extension_id,

content::RenderProcessHost* extension_process)

: weak_message_service_(message_service),

@@ -112,7 +112,7 @@ ExtensionMessagePort::ExtensionMessagePort(

ExtensionMessagePort::ExtensionMessagePort(

base::WeakPtr<MessageService> message_service,

- int port_id,

+ const PortId& port_id,

const std::string& extension_id,

content::RenderFrameHost* rfh,

bool include_child_frames)