Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 2547653002: Remove dead code processing wheel gesture phase. (Closed)

Created:
4 years ago by dtapuska
Modified:
4 years ago
Reviewers:
bokan, jbroman
CC:
darktears, blink-layers+watch_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, kenneth.christiansen, mac-reviews_chromium.org, rjwright, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove dead code processing wheel gesture phase. This code dates back to WebKit with the scroll tree handling mouse wheel events. The calling code was eventually removed yet these functions remained. BUG=625684 Committed: https://crrev.com/3b35a48fdbcd6de3457f979fd8b873eb27935371 Cr-Commit-Position: refs/heads/master@{#435789}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -65 lines) Patch
M third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.h View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp View 1 chunk +0 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/platform/mac/ScrollAnimatorMac.h View 2 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/mac/ScrollAnimatorMac.mm View 2 chunks +0 lines, -34 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollAnimatorBase.h View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
dtapuska
4 years ago (2016-12-01 20:50:48 UTC) #4
bokan
nice find, lgtm
4 years ago (2016-12-01 20:51:55 UTC) #5
jbroman
lgtm
4 years ago (2016-12-01 21:08:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2547653002/1
4 years ago (2016-12-01 21:09:51 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-02 00:22:44 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-02 00:24:13 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3b35a48fdbcd6de3457f979fd8b873eb27935371
Cr-Commit-Position: refs/heads/master@{#435789}

Powered by Google App Engine
This is Rietveld 408576698