Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issue 2547493002: Remove unused code from DuplicateFinder. (Closed)

Created:
4 years ago by vogelheim
Modified:
4 years ago
Reviewers:
Toon Verwaest, marja
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove unused code from DuplicateFinder. BUG=v8:4947 Committed: https://crrev.com/7a8c5049c5445aebfd270840dd659c5207089e6d Cr-Commit-Position: refs/heads/master@{#41453}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -96 lines) Patch
M src/parsing/duplicate-finder.h View 2 chunks +5 lines, -23 lines 0 comments Download
M src/parsing/duplicate-finder.cc View 1 chunk +6 lines, -63 lines 0 comments Download
M src/parsing/parser.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/parsing/parser-base.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/parsing/preparser.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/parsing/scanner.h View 1 chunk +1 line, -1 line 0 comments Download
M src/parsing/scanner.cc View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
vogelheim
ptal This is pretty much a deletion-only CL. It seems DuplicateFinder was originally meant to ...
4 years ago (2016-12-01 11:41:22 UTC) #7
vogelheim
4 years ago (2016-12-02 10:49:29 UTC) #9
marja
lgtm (As discussed offline, duplicatefinder could reuse the hash already computed for the aststring, but ...
4 years ago (2016-12-02 11:45:59 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2547493002/1
4 years ago (2016-12-02 12:08:51 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-02 12:35:05 UTC) #15
commit-bot: I haz the power
4 years ago (2016-12-02 12:35:33 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7a8c5049c5445aebfd270840dd659c5207089e6d
Cr-Commit-Position: refs/heads/master@{#41453}

Powered by Google App Engine
This is Rietveld 408576698