Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(649)

Unified Diff: src/parsing/duplicate-finder.h

Issue 2547493002: Remove unused code from DuplicateFinder. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/parsing/duplicate-finder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/parsing/duplicate-finder.h
diff --git a/src/parsing/duplicate-finder.h b/src/parsing/duplicate-finder.h
index a3858e7c74bbd8c0514feeea9d8678d01481a965..c11c4770366697eac705f404358d3a585dd2ee02 100644
--- a/src/parsing/duplicate-finder.h
+++ b/src/parsing/duplicate-finder.h
@@ -11,25 +11,16 @@
namespace v8 {
namespace internal {
-class UnicodeCache;
-
// DuplicateFinder discovers duplicate symbols.
class DuplicateFinder {
public:
- explicit DuplicateFinder(UnicodeCache* constants)
- : unicode_constants_(constants), backing_store_(16), map_(&Match) {}
+ DuplicateFinder() : backing_store_(16), map_(&Match) {}
- int AddOneByteSymbol(Vector<const uint8_t> key, int value);
- int AddTwoByteSymbol(Vector<const uint16_t> key, int value);
- // Add a a number literal by converting it (if necessary)
- // to the string that ToString(ToNumber(literal)) would generate.
- // and then adding that string with AddOneByteSymbol.
- // This string is the actual value used as key in an object literal,
- // and the one that must be different from the other keys.
- int AddNumber(Vector<const uint8_t> key, int value);
+ bool AddOneByteSymbol(Vector<const uint8_t> key);
+ bool AddTwoByteSymbol(Vector<const uint16_t> key);
private:
- int AddSymbol(Vector<const uint8_t> key, bool is_one_byte, int value);
+ bool AddSymbol(Vector<const uint8_t> key, bool is_one_byte);
// Backs up the key and its length in the backing store.
// The backup is stored with a base 127 encoding of the
// length (plus a bit saying whether the string is one byte),
@@ -40,22 +31,13 @@ class DuplicateFinder {
// for having the same base-127 encoded lengths and representation.
// and then having the same 'length' bytes following.
static bool Match(void* first, void* second);
+
// Creates a hash from a sequence of bytes.
static uint32_t Hash(Vector<const uint8_t> key, bool is_one_byte);
- // Checks whether a string containing a JS number is its canonical
- // form.
- static bool IsNumberCanonical(Vector<const uint8_t> key);
-
- // Size of buffer. Sufficient for using it to call DoubleToCString in
- // from conversions.h.
- static const int kBufferSize = 100;
- UnicodeCache* unicode_constants_;
// Backing store used to store strings used as hashmap keys.
SequenceCollector<unsigned char> backing_store_;
base::CustomMatcherHashMap map_;
- // Buffer used for string->number->canonical string conversions.
- char number_buffer_[kBufferSize];
};
} // namespace internal
« no previous file with comments | « no previous file | src/parsing/duplicate-finder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698