Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Issue 2547433003: [fullcodegen] Remove non-"static" part in VisitArrayLiteral functions. (Closed)

Created:
4 years ago by Franzi
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[fullcodegen] Remove non-"static" part in VisitArrayLiteral functions. The loop for non-"static" properties is no longer needed in full-codegen since all computed property names in object literals go through Ignition first. BUG=v8:5657 Committed: https://crrev.com/51b32c468bcce166211874c80b05669e76300498 Cr-Commit-Position: refs/heads/master@{#41428}

Patch Set 1 #

Patch Set 2 : Replace if with DCHECK. #

Patch Set 3 : Delete unused GetIdForPropertyName #

Patch Set 4 : Simplify loop variable name. #

Patch Set 5 : Simplify bailout id in ObjectLiteral. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -580 lines) Patch
M src/ast/ast.h View 1 2 3 4 1 chunk +2 lines, -9 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 2 3 2 chunks +5 lines, -7 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 2 3 3 chunks +6 lines, -63 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 2 3 3 chunks +6 lines, -63 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 2 3 3 chunks +6 lines, -62 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 2 3 3 chunks +6 lines, -63 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 2 3 3 chunks +6 lines, -63 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 2 3 3 chunks +6 lines, -63 lines 0 comments Download
M src/full-codegen/s390/full-codegen-s390.cc View 1 2 3 3 chunks +6 lines, -63 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 2 3 3 chunks +6 lines, -62 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 2 3 3 chunks +6 lines, -62 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 23 (18 generated)
Franzi
I think I got all the code this time. PTAL. Thanks, Franzi
4 years ago (2016-12-01 13:27:11 UTC) #14
Michael Starzinger
LGTM. Nice! I like it.
4 years ago (2016-12-01 13:33:44 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2547433003/80001
4 years ago (2016-12-01 13:34:20 UTC) #19
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years ago (2016-12-01 13:36:01 UTC) #21
commit-bot: I haz the power
4 years ago (2016-12-01 13:36:19 UTC) #23
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/51b32c468bcce166211874c80b05669e76300498
Cr-Commit-Position: refs/heads/master@{#41428}

Powered by Google App Engine
This is Rietveld 408576698