Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 2546473006: [fullcodegen] Remove non-"static" part in ArrayLiteral. (Closed)

Created:
4 years ago by Franzi
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[fullcodegen] Remove non-"static" part in ArrayLiteral. The loop for non-"static" properties is no longer needed in full-codegen since all computed property names in object literals go through Ignition first. BUG=v8:5657 Committed: https://crrev.com/39d289f59e7479bbb150c9073b432fd99783ebcd Cr-Commit-Position: refs/heads/master@{#41422}

Patch Set 1 #

Patch Set 2 : Delete TryFastToName. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -90 lines) Patch
M src/compiler/ast-graph-builder.h View 1 2 chunks +0 lines, -2 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 4 chunks +1 line, -88 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (12 generated)
Franzi
PTAL. Thanks, Franzi
4 years ago (2016-12-01 10:35:37 UTC) #7
Michael Starzinger
LGTM. Nice! The same can be done to {FullCodeGenerator::VisitObjectLiteral} as well.
4 years ago (2016-12-01 10:38:59 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2546473006/20001
4 years ago (2016-12-01 12:02:52 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-01 12:04:43 UTC) #15
commit-bot: I haz the power
4 years ago (2016-12-01 12:04:59 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/39d289f59e7479bbb150c9073b432fd99783ebcd
Cr-Commit-Position: refs/heads/master@{#41422}

Powered by Google App Engine
This is Rietveld 408576698