Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Issue 2547393002: Correct comment related to WebGLContextGroup's weak references. (Closed)

Created:
4 years ago by Ken Russell (switch to Gerrit)
Modified:
4 years ago
Reviewers:
haraken, sof
CC:
chromium-reviews, blink-reviews, Zhenyao Mo, Kai Ninomiya
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Correct comment related to WebGLContextGroup's weak references. BUG=537054, 666061 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/d41d524c91a312d57f4db7458d9f6ccc250f24c6 Cr-Commit-Position: refs/heads/master@{#436247}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M third_party/WebKit/Source/modules/webgl/WebGLContextGroup.cpp View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Ken Russell (switch to Gerrit)
haraken / sigbjornf: please review this update to this comment, and more generally, please indicate ...
4 years ago (2016-12-05 03:27:10 UTC) #3
haraken
Thanks, this makes a lot of sense. LGTM.
4 years ago (2016-12-05 04:44:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2547393002/1
4 years ago (2016-12-05 05:06:58 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-05 09:21:27 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-05 09:23:07 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d41d524c91a312d57f4db7458d9f6ccc250f24c6
Cr-Commit-Position: refs/heads/master@{#436247}

Powered by Google App Engine
This is Rietveld 408576698