Rename TouchEventAPI to TouchEventFeatureDetection

Rename TouchEventAPI to TouchEventFeatureDetection

We don't really want the "touch event API" support to be dynamic (you can
always open devtools at use mobile emulation to generate touch events).  It's
just the feature detection (eg.'ontouchstart' in window) that needs to be
dynamic due to 632881.

BUG=644318
Committed: https://crrev.com/fa6a8afcca5bb185d7c0a89db6775073b530989e
Cr-Commit-Position: refs/heads/master@{#437464}

[sunyunjia, 2016-12-04 22:35:53]

The CQ bit was checked by sunyunjia@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-04 22:36:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-05 00:24:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-05 00:24:39]

Dry run: This issue passed the CQ dry run.

[sunyunjia, 2016-12-05 15:02:14]

Description was changed from

==========
Rename TouchEventAPI to TouchEventFeatureDetection

BUG=644318
==========

to

==========
Rename TouchEventAPI to TouchEventFeatureDetection

We don't really want the "touch event API" support to be dynamic (you can
always open devtools at use mobile emulation to generate touch events).  It's
just the feature detection (eg.'ontouchstart' in window) that needs to be
dynamic due to 632881.

BUG=644318
==========

[sunyunjia, 2016-12-05 15:02:15]

sunyunjia@chromium.org changed reviewers:
+ mustaq@chromium.org

[sunyunjia, 2016-12-05 15:02:48]

PTAL, thanks!

[mustaq, 2016-12-05 16:30:34]

https://codereview.chromium.org/2547373002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp
(right):

https://codereview.chromium.org/2547373002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp:661: if
(!RuntimeEnabledFeatures::touchEventFeatureDetectionEnabled())
I think all refs to touchEventFeatureDetectionEnabled in this class should go
away since we are always firing touch events.

Keep your change here to ensure this is a refactor-only CL. But Please add a
TODO.

[mustaq, 2016-12-05 18:18:02]

https://codereview.chromium.org/2547373002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp
(right):

https://codereview.chromium.org/2547373002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp:661: if
(!RuntimeEnabledFeatures::touchEventFeatureDetectionEnabled())
On 2016/12/05 16:30:34, mustaq wrote:
> I think all refs to touchEventFeatureDetectionEnabled in this class should go
> away since we are always firing touch events.
> 
> Keep your change here to ensure this is a refactor-only CL. But Please add a
> TODO.

Please add crbug.com/671232 to the TODO.

[sunyunjia, 2016-12-06 15:55:49]

Hi Mustaq, should we send this for owner's approval now?

https://codereview.chromium.org/2547373002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp
(right):

https://codereview.chromium.org/2547373002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp:661: if
(!RuntimeEnabledFeatures::touchEventFeatureDetectionEnabled())
On 2016/12/05 18:18:02, mustaq wrote:
> On 2016/12/05 16:30:34, mustaq wrote:
> > I think all refs to touchEventFeatureDetectionEnabled in this class should
go
> > away since we are always firing touch events.
> > 
> > Keep your change here to ensure this is a refactor-only CL. But Please add a
> > TODO.
> 
> Please add crbug.com/671232 to the TODO.

Done.

https://codereview.chromium.org/2547373002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp:661: if
(!RuntimeEnabledFeatures::touchEventFeatureDetectionEnabled())
On 2016/12/05 16:30:34, mustaq wrote:
> I think all refs to touchEventFeatureDetectionEnabled in this class should go
> away since we are always firing touch events.
> 
> Keep your change here to ensure this is a refactor-only CL. But Please add a
> TODO.

Done.

[mustaq, 2016-12-06 15:58:16]

LGTM.

[sunyunjia, 2016-12-06 16:27:14]

sunyunjia@chromium.org changed reviewers:
+ avi@chromium.org, dcheng@chromium.org, isherman@chromium.org,
rbyers@chromium.org, stevenjb@chromium.org

[sunyunjia, 2016-12-06 16:29:37]

sunyunjia@chromium.org changed reviewers:
+ tapted@chromium.org
- avi@chromium.org

[sunyunjia, 2016-12-06 16:36:54]

sunyunjia@chromium.org changed reviewers:
+ clamy@chromium.org

[sunyunjia, 2016-12-06 16:38:16]

sunyunjia@chromium.org changed reviewers:
+ sadrul@chromium.org
- clamy@chromium.org

[sunyunjia, 2016-12-06 16:38:56]

sunyunjia@chromium.org changed reviewers:
+ clamy@chromium.org

[sunyunjia, 2016-12-06 16:40:07]

The CQ bit was checked by sunyunjia@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-06 16:40:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sunyunjia, 2016-12-06 16:41:11]

PTAL, thanks!

[commit-bot: I haz the power, 2016-12-06 16:43:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-06 16:43:07]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Rick Byers, 2016-12-06 16:48:12]

LGTM, thanks - sorry I didn't suggest this sooner!  Makes a lot more sense now
IMHO.

https://codereview.chromium.org/2547373002/diff/20001/chrome/browser/metrics/...
File chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc (right):

https://codereview.chromium.org/2547373002/diff/20001/chrome/browser/metrics/...
chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc:103: enum
UMATouchEventFeatureDetectionState {
I _think_ you want to update the enum in histograms.xml too (as the comment on
108 below says).  Since we're not changing any values or semantics, it should be
safe to just change the names (just affects uma dashboard UI).

[stevenjb, 2016-12-06 16:59:03]

c/b/chromeos owner lgtm

[sunyunjia, 2016-12-06 18:51:27]

The CQ bit was checked by sunyunjia@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-06 18:52:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dcheng, 2016-12-06 19:31:51]

rs lgtm for ipc (I assume that's the only thing I'm an OWNER for? Maybe send out
who should be reviewing what =)

[sunyunjia, 2016-12-06 21:53:40]

Thanks rbyers, stevenjb and dcheng!

isherman@: Could you please review the code in chrome/browser/metrics and
tools/metrics/histograms/?
clamy@: Could you please review the code in content/?
sadrul@: Could you please review the code in content/browser/renderer_host/,
content/browser/web_contents/ and ui/events?
tapted@: Could you please review the code in chrome/browser/apps/guest_view/?

https://codereview.chromium.org/2547373002/diff/20001/chrome/browser/metrics/...
File chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc (right):

https://codereview.chromium.org/2547373002/diff/20001/chrome/browser/metrics/...
chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc:103: enum
UMATouchEventFeatureDetectionState {
On 2016/12/06 16:48:12, Rick Byers wrote:
> I _think_ you want to update the enum in histograms.xml too (as the comment on
> 108 below says).  Since we're not changing any values or semantics, it should
be
> safe to just change the names (just affects uma dashboard UI).

Done.

[Ilya Sherman, 2016-12-06 21:55:53]

metrics LGTM, thanks

https://codereview.chromium.org/2547373002/diff/60001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2547373002/diff/60001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:67421: +    through 45, see
http://crbug.com/499476 for more details. As
nit: Should this say "As of"?

[tapted, 2016-12-06 22:36:43]

chrome/browser/apps/ lgtm

[commit-bot: I haz the power, 2016-12-06 23:11:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-06 23:11:32]

Dry run: This issue passed the CQ dry run.

[sadrul, 2016-12-07 02:55:59]

https://codereview.chromium.org/2547373002/diff/60001/ui/events/event_switches.h
File ui/events/event_switches.h (right):

https://codereview.chromium.org/2547373002/diff/60001/ui/events/event_switche...
ui/events/event_switches.h:18: EVENTS_BASE_EXPORT extern const char
kTouchEventFeatureDetectionDisabled[];
Can you move these out of ui and into content, since that's where these are
being used? (maybe in content/public/common/content_switches.h so that it can be
used from browser, renderer, and also from /chrome)

[sunyunjia, 2016-12-07 15:32:23]

The CQ bit was checked by sunyunjia@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-07 15:32:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 18:16:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 18:16:46]

Dry run: This issue passed the CQ dry run.

[sunyunjia, 2016-12-07 18:24:25]

sadrul@: PTAL, thanks!

https://codereview.chromium.org/2547373002/diff/60001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2547373002/diff/60001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:67421: +    through 45, see
http://crbug.com/499476 for more details. As
On 2016/12/06 21:55:52, Ilya Sherman wrote:
> nit: Should this say "As of"?

Done.

https://codereview.chromium.org/2547373002/diff/60001/ui/events/event_switches.h
File ui/events/event_switches.h (right):

https://codereview.chromium.org/2547373002/diff/60001/ui/events/event_switche...
ui/events/event_switches.h:18: EVENTS_BASE_EXPORT extern const char
kTouchEventFeatureDetectionDisabled[];
On 2016/12/07 02:55:59, sadrul wrote:
> Can you move these out of ui and into content, since that's where these are
> being used? (maybe in content/public/common/content_switches.h so that it can
be
> used from browser, renderer, and also from /chrome)

Done.

[sadrul, 2016-12-08 01:14:42]

Thank you! lgtm

[clamy, 2016-12-08 13:26:30]

Thanks! content/ lgtm. Note that you will need another reviewer for the content/
IPC change :).

[sunyunjia, 2016-12-08 14:48:28]

The CQ bit was checked by sunyunjia@chromium.org

[sunyunjia, 2016-12-08 14:48:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
stevenjb@chromium.org, rbyers@chromium.org, mustaq@chromium.org,
tapted@chromium.org, isherman@chromium.org, dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2547373002/#ps80001
(title: "Move the switches out of ui and into content.")

[commit-bot: I haz the power, 2016-12-08 14:48:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 14:52:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 14:52:54]

Failed to apply patch for chrome/browser/about_flags.cc:
While running git apply --index -p1;
  error: patch failed: chrome/browser/about_flags.cc:1989
  error: chrome/browser/about_flags.cc: patch does not apply

Patch:       chrome/browser/about_flags.cc
Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index
daeeff616d1e709ae7dfa24e6275c91b7f09ecda..a9a56c33f85f92763eec0e075baafc4d48496903
100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -134,14 +134,14 @@ namespace {
 const unsigned kOsAll = kOsMac | kOsWin | kOsLinux | kOsCrOS | kOsAndroid;
 const unsigned kOsDesktop = kOsMac | kOsWin | kOsLinux | kOsCrOS;
 
-const FeatureEntry::Choice kTouchEventsChoices[] = {
+const FeatureEntry::Choice kTouchEventFeatureDetectionChoices[] = {
   { IDS_GENERIC_EXPERIMENT_CHOICE_AUTOMATIC, "", "" },
   { IDS_GENERIC_EXPERIMENT_CHOICE_ENABLED,
-    switches::kTouchEvents,
-    switches::kTouchEventsEnabled },
+    switches::kTouchEventFeatureDetection,
+    switches::kTouchEventFeatureDetectionEnabled },
   { IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED,
-    switches::kTouchEvents,
-    switches::kTouchEventsDisabled }
+    switches::kTouchEventFeatureDetection,
+    switches::kTouchEventFeatureDetectionDisabled }
 };
 
 #if defined(USE_AURA)
@@ -865,7 +865,7 @@ const FeatureEntry kFeatureEntries[] = {
      SINGLE_VALUE_TYPE(switches::kExtendMdToSecondaryUi)},
     {"touch-events", IDS_FLAGS_TOUCH_EVENTS_NAME,
      IDS_FLAGS_TOUCH_EVENTS_DESCRIPTION, kOsDesktop,
-     MULTI_VALUE_TYPE(kTouchEventsChoices)},
+     MULTI_VALUE_TYPE(kTouchEventFeatureDetectionChoices)},
     {"disable-touch-adjustment", IDS_FLAGS_TOUCH_ADJUSTMENT_NAME,
      IDS_FLAGS_TOUCH_ADJUSTMENT_DESCRIPTION,
      kOsWin | kOsLinux | kOsCrOS | kOsAndroid,
@@ -1989,8 +1989,7 @@ const FeatureEntry kFeatureEntries[] = {
      FEATURE_VALUE_TYPE(media::kNewAudioRenderingMixingStrategy)},
     {"disable-background-video-track",
      IDS_BACKGROUND_VIDEO_TRACK_OPTIMIZATION_NAME,
-     IDS_BACKGROUND_VIDEO_TRACK_OPTIMIZATION_DESCRIPTION,
-     kOsAll,
+     IDS_BACKGROUND_VIDEO_TRACK_OPTIMIZATION_DESCRIPTION, kOsAll,
      FEATURE_VALUE_TYPE(media::kBackgroundVideoTrackOptimization)},
 #if defined(OS_CHROMEOS)
     {"files-quick-view", IDS_FLAGS_FILES_QUICK_VIEW_NAME,
@@ -2087,8 +2086,7 @@ const FeatureEntry kFeatureEntries[] = {
      IDS_FLAGS_OFFLINE_PAGES_SVELTE_CONCURRENT_LOADING_DESCRIPTION, kOsAndroid,
      FEATURE_VALUE_TYPE(
          offline_pages::kOfflinePagesSvelteConcurrentLoadingFeature)},
-    {"web-payments-modifiers",
-     IDS_FLAGS_WEB_PAYMENTS_MODIFIERS_NAME,
+    {"web-payments-modifiers", IDS_FLAGS_WEB_PAYMENTS_MODIFIERS_NAME,
      IDS_FLAGS_WEB_PAYMENTS_MODIFIERS_DESCRIPTION, kOsAndroid,
      FEATURE_VALUE_TYPE(chrome::android::kWebPaymentsModifiers)},
 #endif

[sunyunjia, 2016-12-08 15:04:44]

The CQ bit was checked by sunyunjia@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 15:05:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 16:59:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 16:59:17]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[sunyunjia, 2016-12-08 18:02:58]

The CQ bit was checked by sunyunjia@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 18:03:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 18:13:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 18:13:33]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[sunyunjia, 2016-12-08 18:16:58]

The CQ bit was checked by sunyunjia@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 18:17:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 20:41:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 20:41:06]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[sunyunjia, 2016-12-09 02:12:41]

The CQ bit was checked by sunyunjia@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-09 02:13:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 03:55:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-09 03:55:40]

Dry run: This issue passed the CQ dry run.

[sunyunjia, 2016-12-09 04:20:18]

The CQ bit was checked by sunyunjia@chromium.org

[sunyunjia, 2016-12-09 04:20:19]

The patchset sent to the CQ was uploaded after l-g-t-m from tapted@chromium.org,
stevenjb@chromium.org, sadrul@chromium.org, isherman@chromium.org,
dcheng@chromium.org, rbyers@chromium.org, clamy@chromium.org,
mustaq@chromium.org
Link to the patchset: https://codereview.chromium.org/2547373002/#ps120001
(title: "Merge branch 'master' of https://chromium.googlesource.com/chromium/src
into rename")

[commit-bot: I haz the power, 2016-12-09 04:20:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 04:25:52]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1481257218544910,
"parent_rev": "dc6e945aef04d2dd480e62cd0ff7dcc2698266e6", "commit_rev":
"6c9ce2b4ad575a4d379e4bbaabe4fb0830a17ccc"}

[commit-bot: I haz the power, 2016-12-09 04:26:18]

Description was changed from

==========
Rename TouchEventAPI to TouchEventFeatureDetection

We don't really want the "touch event API" support to be dynamic (you can
always open devtools at use mobile emulation to generate touch events).  It's
just the feature detection (eg.'ontouchstart' in window) that needs to be
dynamic due to 632881.

BUG=644318
==========

to

==========
Rename TouchEventAPI to TouchEventFeatureDetection

We don't really want the "touch event API" support to be dynamic (you can
always open devtools at use mobile emulation to generate touch events).  It's
just the feature detection (eg.'ontouchstart' in window) that needs to be
dynamic due to 632881.

BUG=644318
==========

[commit-bot: I haz the power, 2016-12-09 04:26:21]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-12-09 04:28:55]

Description was changed from

==========
Rename TouchEventAPI to TouchEventFeatureDetection

We don't really want the "touch event API" support to be dynamic (you can
always open devtools at use mobile emulation to generate touch events).  It's
just the feature detection (eg.'ontouchstart' in window) that needs to be
dynamic due to 632881.

BUG=644318
==========

to

==========
Rename TouchEventAPI to TouchEventFeatureDetection

We don't really want the "touch event API" support to be dynamic (you can
always open devtools at use mobile emulation to generate touch events).  It's
just the feature detection (eg.'ontouchstart' in window) that needs to be
dynamic due to 632881.

BUG=644318

Committed: https://crrev.com/fa6a8afcca5bb185d7c0a89db6775073b530989e
Cr-Commit-Position: refs/heads/master@{#437464}
==========

[commit-bot: I haz the power, 2016-12-09 04:28:57]

Patchset 7 (id:??) landed as
https://crrev.com/fa6a8afcca5bb185d7c0a89db6775073b530989e
Cr-Commit-Position: refs/heads/master@{#437464}