Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Side by Side Diff: chrome/browser/metrics/chrome_browser_main_extra_parts_metrics_unittest.cc

Issue 2547373002: Rename TouchEventAPI to TouchEventFeatureDetection (Closed)
Patch Set: Merge branch 'master' of https://chromium.googlesource.com/chromium/src into rename Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.h" 5 #include "chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.h"
6 6
7 #include <memory> 7 #include <memory>
8 8
9 #include "base/macros.h" 9 #include "base/macros.h"
10 #include "base/message_loop/message_loop.h" 10 #include "base/message_loop/message_loop.h"
11 #include "base/test/histogram_tester.h" 11 #include "base/test/histogram_tester.h"
12 #include "testing/gtest/include/gtest/gtest.h" 12 #include "testing/gtest/include/gtest/gtest.h"
13 #include "ui/display/screen.h" 13 #include "ui/display/screen.h"
14 #include "ui/display/test/test_screen.h" 14 #include "ui/display/test/test_screen.h"
15 #include "ui/events/test/device_data_manager_test_api.h" 15 #include "ui/events/test/device_data_manager_test_api.h"
16 #include "ui/gfx/geometry/size.h" 16 #include "ui/gfx/geometry/size.h"
17 17
18 namespace { 18 namespace {
19 19
20 const char kTouchEventsEnabledHistogramName[] = 20 const char kTouchEventFeatureDetectionEnabledHistogramName[] =
21 "Touchscreen.TouchEventsEnabled"; 21 "Touchscreen.TouchEventsEnabled";
22 22
23 } // namespace 23 } // namespace
24 24
25 class ChromeBrowserMainExtraPartsMetricsTest : public testing::Test { 25 class ChromeBrowserMainExtraPartsMetricsTest : public testing::Test {
26 public: 26 public:
27 ChromeBrowserMainExtraPartsMetricsTest(); 27 ChromeBrowserMainExtraPartsMetricsTest();
28 ~ChromeBrowserMainExtraPartsMetricsTest() override; 28 ~ChromeBrowserMainExtraPartsMetricsTest() override;
29 29
30 protected: 30 protected:
(...skipping 18 matching lines...) Expand all
49 ChromeBrowserMainExtraPartsMetricsTest:: 49 ChromeBrowserMainExtraPartsMetricsTest::
50 ~ChromeBrowserMainExtraPartsMetricsTest() { 50 ~ChromeBrowserMainExtraPartsMetricsTest() {
51 display::Screen::SetScreenInstance(nullptr); 51 display::Screen::SetScreenInstance(nullptr);
52 } 52 }
53 53
54 // Verify a TouchEventsEnabled value isn't recorded during construction. 54 // Verify a TouchEventsEnabled value isn't recorded during construction.
55 TEST_F(ChromeBrowserMainExtraPartsMetricsTest, 55 TEST_F(ChromeBrowserMainExtraPartsMetricsTest,
56 VerifyTouchEventsEnabledIsNotRecordedAfterConstruction) { 56 VerifyTouchEventsEnabledIsNotRecordedAfterConstruction) {
57 base::HistogramTester histogram_tester; 57 base::HistogramTester histogram_tester;
58 ChromeBrowserMainExtraPartsMetrics test_target; 58 ChromeBrowserMainExtraPartsMetrics test_target;
59 histogram_tester.ExpectTotalCount(kTouchEventsEnabledHistogramName, 0); 59 histogram_tester.ExpectTotalCount(
60 kTouchEventFeatureDetectionEnabledHistogramName, 0);
60 } 61 }
61 62
62 #if defined(USE_OZONE) || defined(USE_X11) 63 #if defined(USE_OZONE) || defined(USE_X11)
63 64
64 // Verify a TouchEventsEnabled value isn't recorded during PostBrowserStart if 65 // Verify a TouchEventsEnabled value isn't recorded during PostBrowserStart if
65 // the device scan hasn't completed yet. 66 // the device scan hasn't completed yet.
66 TEST_F(ChromeBrowserMainExtraPartsMetricsTest, 67 TEST_F(ChromeBrowserMainExtraPartsMetricsTest,
67 VerifyTouchEventsEnabledIsNotRecordedAfterPostBrowserStart) { 68 VerifyTouchEventsEnabledIsNotRecordedAfterPostBrowserStart) {
68 base::HistogramTester histogram_tester; 69 base::HistogramTester histogram_tester;
69 70
70 ChromeBrowserMainExtraPartsMetrics test_target; 71 ChromeBrowserMainExtraPartsMetrics test_target;
71 72
72 test_target.PostBrowserStart(); 73 test_target.PostBrowserStart();
73 histogram_tester.ExpectTotalCount(kTouchEventsEnabledHistogramName, 0); 74 histogram_tester.ExpectTotalCount(
75 kTouchEventFeatureDetectionEnabledHistogramName, 0);
74 } 76 }
75 77
76 // Verify a TouchEventsEnabled value is recorded during PostBrowserStart if the 78 // Verify a TouchEventsEnabled value is recorded during PostBrowserStart if the
77 // device scan has already completed. 79 // device scan has already completed.
78 TEST_F(ChromeBrowserMainExtraPartsMetricsTest, 80 TEST_F(ChromeBrowserMainExtraPartsMetricsTest,
79 VerifyTouchEventsEnabledIsRecordedAfterPostBrowserStart) { 81 VerifyTouchEventsEnabledIsRecordedAfterPostBrowserStart) {
80 base::HistogramTester histogram_tester; 82 base::HistogramTester histogram_tester;
81 83
82 device_data_manager_test_api_.OnDeviceListsComplete(); 84 device_data_manager_test_api_.OnDeviceListsComplete();
83 85
84 ChromeBrowserMainExtraPartsMetrics test_target; 86 ChromeBrowserMainExtraPartsMetrics test_target;
85 87
86 test_target.PostBrowserStart(); 88 test_target.PostBrowserStart();
87 histogram_tester.ExpectTotalCount(kTouchEventsEnabledHistogramName, 1); 89 histogram_tester.ExpectTotalCount(
90 kTouchEventFeatureDetectionEnabledHistogramName, 1);
88 } 91 }
89 92
90 // Verify a TouchEventsEnabled value is recorded when an asynchronous device 93 // Verify a TouchEventsEnabled value is recorded when an asynchronous device
91 // scan completes. 94 // scan completes.
92 TEST_F(ChromeBrowserMainExtraPartsMetricsTest, 95 TEST_F(ChromeBrowserMainExtraPartsMetricsTest,
93 VerifyTouchEventsEnabledIsRecordedWhenDeviceListsComplete) { 96 VerifyTouchEventsEnabledIsRecordedWhenDeviceListsComplete) {
94 base::HistogramTester histogram_tester; 97 base::HistogramTester histogram_tester;
95 ChromeBrowserMainExtraPartsMetrics test_target; 98 ChromeBrowserMainExtraPartsMetrics test_target;
96 99
97 test_target.PostBrowserStart(); 100 test_target.PostBrowserStart();
98 device_data_manager_test_api_.NotifyObserversDeviceListsComplete(); 101 device_data_manager_test_api_.NotifyObserversDeviceListsComplete();
99 histogram_tester.ExpectTotalCount(kTouchEventsEnabledHistogramName, 1); 102 histogram_tester.ExpectTotalCount(
103 kTouchEventFeatureDetectionEnabledHistogramName, 1);
100 } 104 }
101 105
102 // Verify a TouchEventsEnabled value is only recorded once if multiple 106 // Verify a TouchEventsEnabled value is only recorded once if multiple
103 // asynchronous device scans happen. 107 // asynchronous device scans happen.
104 TEST_F(ChromeBrowserMainExtraPartsMetricsTest, 108 TEST_F(ChromeBrowserMainExtraPartsMetricsTest,
105 VerifyTouchEventsEnabledIsOnlyRecordedOnce) { 109 VerifyTouchEventsEnabledIsOnlyRecordedOnce) {
106 base::HistogramTester histogram_tester; 110 base::HistogramTester histogram_tester;
107 ChromeBrowserMainExtraPartsMetrics test_target; 111 ChromeBrowserMainExtraPartsMetrics test_target;
108 112
109 test_target.PostBrowserStart(); 113 test_target.PostBrowserStart();
110 device_data_manager_test_api_.NotifyObserversDeviceListsComplete(); 114 device_data_manager_test_api_.NotifyObserversDeviceListsComplete();
111 device_data_manager_test_api_.NotifyObserversDeviceListsComplete(); 115 device_data_manager_test_api_.NotifyObserversDeviceListsComplete();
112 histogram_tester.ExpectTotalCount(kTouchEventsEnabledHistogramName, 1); 116 histogram_tester.ExpectTotalCount(
117 kTouchEventFeatureDetectionEnabledHistogramName, 1);
113 } 118 }
114 119
115 #else 120 #else
116 121
117 // Verify a TouchEventsEnabled value is recorded during PostBrowserStart. 122 // Verify a TouchEventsEnabled value is recorded during PostBrowserStart.
118 TEST_F(ChromeBrowserMainExtraPartsMetricsTest, 123 TEST_F(ChromeBrowserMainExtraPartsMetricsTest,
119 VerifyTouchEventsEnabledIsRecordedAfterPostBrowserStart) { 124 VerifyTouchEventsEnabledIsRecordedAfterPostBrowserStart) {
120 base::HistogramTester histogram_tester; 125 base::HistogramTester histogram_tester;
121 ChromeBrowserMainExtraPartsMetrics test_target; 126 ChromeBrowserMainExtraPartsMetrics test_target;
122 127
123 test_target.PostBrowserStart(); 128 test_target.PostBrowserStart();
124 histogram_tester.ExpectTotalCount(kTouchEventsEnabledHistogramName, 1); 129 histogram_tester.ExpectTotalCount(
130 kTouchEventFeatureDetectionEnabledHistogramName, 1);
125 } 131 }
126 132
127 #endif // defined(USE_OZONE) || defined(USE_X11) 133 #endif // defined(USE_OZONE) || defined(USE_X11)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698