In webkit-patch rebaseline-cl, abort if results are missing.

third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py

Index: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py
index 874130a836f0a391d026b6ac2677c7fde5e2c569..aad4349e13c41c0fe4d52eaa98fbc0cae41cb018 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py
@@ -51,8 +51,8 @@ class RebaselineCLTest(BaseTestCase, LoggingTestCase):
                 "is_try_builder": True,
             },
             "MOCK Try Linux": {
-                "port_name": "test-mac-mac10.10",
-                "specifiers": ["Mac10.10", "Release"],
+                "port_name": "test-linux-trusty",
+                "specifiers": ["Trusty", "Release"],
                 "is_try_builder": True,
             },
         })
@@ -237,3 +237,13 @@ class RebaselineCLTest(BaseTestCase, LoggingTestCase):
             'INFO: Triggering try jobs for:\n',
             'INFO:   MOCK Try Win\n',
         ])
+
+    def test_bails_when_one_build_is_missing_results(self):
+        self.tool.buildbot.set_results(Build("MOCK Try Win", 5000), None)

[wkorman, 2016/12/05 05:58:35]

Perhaps worth a test case that has at least one with results as well.

[qyearsley, 2016/12/05 17:55:21]

Currently test_execute_with_issue_number_given (and several of the other methods
above) test the case where there is results -- but they don't explicitly set the
results. Instead, they rely on results implicitly set by default in MockBuildBot
(self.tool.buildbot).

I think it would be better to set results explicitly though, maybe in the setUp
method for this class. Sound good?

[wkorman, 2016/12/05 18:56:25]

Ah, I see. Yes, that wasn't immediately apparent. Does not need to be changed in
this CL, up to you.

[qyearsley, 2016/12/07 00:42:27]

Probably nicer to make this change in a separate CL, I think.

+        self.command.execute(self.command_options(issue=11112222), [], self.tool)
+        self.assertLog([
+            'ERROR: Failed to fetch results from '
+            '"https://storage.googleapis.com/chromium-layout-test-archives/MOCK_Try_Win/5000/layout-test-results".\n'
+            'Try starting a new job for MOCK Try Win by running :\n'
+            '  git cl try -b MOCK Try Win\n'
+        ])