In webkit-patch rebaseline-cl, abort if results are missing.

third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import json
 import optparse
 
 from webkitpy.common.net.buildbot import Build
 from webkitpy.common.net.git_cl import GitCL
 from webkitpy.common.net.rietveld import Rietveld
@@ skipping 33 matching lines @@
                 },
             }),
         })
         self.tool.builders = BuilderList({
             "MOCK Try Win": {
                 "port_name": "test-win-win7",
                 "specifiers": ["Win7", "Release"],
                 "is_try_builder": True,
             },
             "MOCK Try Linux": {
-                "port_name": "test-mac-mac10.10",
-                "specifiers": ["Mac10.10", "Release"],
+                "port_name": "test-linux-trusty",
+                "specifiers": ["Trusty", "Release"],
                 "is_try_builder": True,
             },
         })
         self.command.rietveld = Rietveld(web)
 
         self.tool.buildbot.set_retry_sumary_json(Build('MOCK Try Win', 5000), json.dumps({
             'failures': [
                 'fast/dom/prototype-newtest.html',
                 'fast/dom/prototype-taco.html',
                 'fast/dom/prototype-inheritance.html',
@@ skipping 164 matching lines @@
         self.assertTrue(self.command.trigger_jobs_for_missing_builds([
             Build('MOCK Try Linux', None),
         ]))
         self.assertEqual(self.tool.executive.calls, [['git', 'cl', 'try', '-b', 'MOCK Try Win']])
         self.assertLog([
             'INFO: There are existing pending builds for:\n',
             'INFO:   MOCK Try Linux\n',
             'INFO: Triggering try jobs for:\n',
             'INFO:   MOCK Try Win\n',
         ])
+
+    def test_bails_when_one_build_is_missing_results(self):
+        self.tool.buildbot.set_results(Build("MOCK Try Win", 5000), None)

[wkorman, 2016/12/05 05:58:35]

Perhaps worth a test case that has at least one with results as well.

[qyearsley, 2016/12/05 17:55:21]

Currently test_execute_with_issue_number_given (and several of the other methods
above) test the case where there is results -- but they don't explicitly set the
results. Instead, they rely on results implicitly set by default in MockBuildBot
(self.tool.buildbot).

I think it would be better to set results explicitly though, maybe in the setUp
method for this class. Sound good?

[wkorman, 2016/12/05 18:56:25]

Ah, I see. Yes, that wasn't immediately apparent. Does not need to be changed in
this CL, up to you.

[qyearsley, 2016/12/07 00:42:27]

Probably nicer to make this change in a separate CL, I think.

+        self.command.execute(self.command_options(issue=11112222), [], self.tool)
+        self.assertLog([
+            'ERROR: Failed to fetch results from '
+            '"https://storage.googleapis.com/chromium-layout-test-archives/MOCK_Try_Win/5000/layout-test-results".\n'
+            'Try starting a new job for MOCK Try Win by running :\n'
+            '  git cl try -b MOCK Try Win\n'
+        ])