Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Unified Diff: third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

Issue 2546993003: [MediaElement] Allow preloading for non-network scheme src (Closed)
Patch Set: rebased Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp b/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
index 49afa3146a37a67f9947b9891dd9ee4d4341cb18..d9a00f3ae0029fb5267e383d3f68fc76ade135ed 100644
--- a/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
@@ -2073,7 +2073,9 @@ WebMediaPlayer::Preload HTMLMediaElement::preloadType() const {
// Force preload to 'none' on Data Saver and for low end devices.
mlamouri (slow - plz ping) 2016/12/05 13:32:44 Can you update the comment? Or actually remove it
Zhiqiang Zhang (Slow) 2016/12/05 16:32:19 Updated comments.
if (document().settings() &&
(document().settings()->dataSaverEnabled() ||
- document().settings()->forcePreloadNoneForMediaElements())) {
+ document().settings()->forcePreloadNoneForMediaElements()) &&
+ (m_currentSrc.protocol() != "blob" && m_currentSrc.protocol() != "data" &&
+ m_currentSrc.protocol() != "file")) {
UseCounter::count(document(),
UseCounter::HTMLMediaElementPreloadForcedNone);
return WebMediaPlayer::PreloadNone;

Powered by Google App Engine
This is Rietveld 408576698