[MediaElement] Allow preloading for non-network scheme src

[MediaElement] Allow preloading for non-network scheme src

This CL weakens the restriction of media element preloading. The
reason for this change is that the preload attribute for media
elements is overriden as "none" when data saver is
enabled. However there is no need to apply this override for
non-network media sources, since they do not cost network
traffic.

BUG=661220
Committed: https://crrev.com/f9d8e609f1298c6a563274fbdbe6ee5c45df3034
Cr-Commit-Position: refs/heads/master@{#436358}

[Zhiqiang Zhang (Slow), 2016-12-04 22:45:28]

Description was changed from

==========
[MediaElement] Allow preloading for non-network scheme src

This CL weakens the restriction of media element preloading. None

BUG=
==========

to

==========
[MediaElement] Allow preloading for non-network scheme src

This CL weakens the restriction of media element preloading. The
reason for this change is that the preload attribute for media
elements is overriden as "none" when data saver is
enabled. However there is no need to apply this override for
non-network media sources, since they do not cost network
traffic.

BUG=661220
==========

[Zhiqiang Zhang (Slow), 2016-12-04 22:45:40]

zqzhang@chromium.org changed reviewers:
+ mlamouri@chromium.org

[mlamouri (slow - plz ping), 2016-12-05 13:28:13]

The CQ bit was checked by mlamouri@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-05 13:28:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mlamouri (slow - plz ping), 2016-12-05 13:32:44]

lgtm with comments applied.

https://codereview.chromium.org/2546993003/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/http/tests/media/preload-conditions.html
(right):

https://codereview.chromium.org/2546993003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/media/preload-conditions.html:7:
console.log("abc");
I guess this is a leftover from testing?

https://codereview.chromium.org/2546993003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/HTMLMediaElement.cpp (right):

https://codereview.chromium.org/2546993003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/HTMLMediaElement.cpp:2073: // Force preload
to 'none' on Data Saver and for low end devices.
Can you update the comment? Or actually remove it because it just describes in
words what's in the condition.

[commit-bot: I haz the power, 2016-12-05 14:34:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-05 14:34:54]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[Zhiqiang Zhang (Slow), 2016-12-05 16:32:20]

https://codereview.chromium.org/2546993003/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/http/tests/media/preload-conditions.html
(right):

https://codereview.chromium.org/2546993003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/media/preload-conditions.html:7:
console.log("abc");
On 2016/12/05 13:32:44, mlamouri wrote:
> I guess this is a leftover from testing?

Thanks for catching this. Fixed :)

https://codereview.chromium.org/2546993003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/HTMLMediaElement.cpp (right):

https://codereview.chromium.org/2546993003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/HTMLMediaElement.cpp:2073: // Force preload
to 'none' on Data Saver and for low end devices.
On 2016/12/05 13:32:44, mlamouri wrote:
> Can you update the comment? Or actually remove it because it just describes in
> words what's in the condition.

Updated comments.

[Zhiqiang Zhang (Slow), 2016-12-05 16:32:34]

The CQ bit was checked by zqzhang@chromium.org

[Zhiqiang Zhang (Slow), 2016-12-05 16:32:35]

The patchset sent to the CQ was uploaded after l-g-t-m from
mlamouri@chromium.org
Link to the patchset: https://codereview.chromium.org/2546993003/#ps60001
(title: "nits")

[commit-bot: I haz the power, 2016-12-05 16:33:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-05 18:25:51]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1480955554848360,
"parent_rev": "c84d1f4f53ed3e6438bf1a131f19237395fc9b48", "commit_rev":
"9bf8cfa75ce3ded68093de6e8ef24554bc5685b2"}

[commit-bot: I haz the power, 2016-12-05 18:26:21]

Description was changed from

==========
[MediaElement] Allow preloading for non-network scheme src

This CL weakens the restriction of media element preloading. The
reason for this change is that the preload attribute for media
elements is overriden as "none" when data saver is
enabled. However there is no need to apply this override for
non-network media sources, since they do not cost network
traffic.

BUG=661220
==========

to

==========
[MediaElement] Allow preloading for non-network scheme src

This CL weakens the restriction of media element preloading. The
reason for this change is that the preload attribute for media
elements is overriden as "none" when data saver is
enabled. However there is no need to apply this override for
non-network media sources, since they do not cost network
traffic.

BUG=661220
==========

[commit-bot: I haz the power, 2016-12-05 18:26:22]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-12-05 18:28:43]

Description was changed from

==========
[MediaElement] Allow preloading for non-network scheme src

This CL weakens the restriction of media element preloading. The
reason for this change is that the preload attribute for media
elements is overriden as "none" when data saver is
enabled. However there is no need to apply this override for
non-network media sources, since they do not cost network
traffic.

BUG=661220
==========

to

==========
[MediaElement] Allow preloading for non-network scheme src

This CL weakens the restriction of media element preloading. The
reason for this change is that the preload attribute for media
elements is overriden as "none" when data saver is
enabled. However there is no need to apply this override for
non-network media sources, since they do not cost network
traffic.

BUG=661220

Committed: https://crrev.com/f9d8e609f1298c6a563274fbdbe6ee5c45df3034
Cr-Commit-Position: refs/heads/master@{#436358}
==========

[commit-bot: I haz the power, 2016-12-05 18:28:44]

Patchset 4 (id:??) landed as
https://crrev.com/f9d8e609f1298c6a563274fbdbe6ee5c45df3034
Cr-Commit-Position: refs/heads/master@{#436358}