Replace unique_ptr.reset/release with std::move under src/ui

Replace unique_ptr.reset/release with std::move under src/ui

Also replace linked_ptr with unique_ptr in MenuController::NestedState

BUG=644626, 556939
Committed: https://crrev.com/14742b2f2c45a16743d0176d8e654302db6a67bf
Cr-Commit-Position: refs/heads/master@{#437001}

[Sunny, 2016-12-06 03:52:54]

Description was changed from

==========
Replace unique_ptr.reset/release with std::move under src/ui

Also replace linked_ptr with unique_ptr in MenuController::NestedState

R=sadrul@chromium.org
BUG=644626,556939
==========

to

==========
Replace unique_ptr.reset/release with std::move under src/ui

Also replace linked_ptr with unique_ptr in MenuController::NestedState

BUG=644626,556939
==========

[Sunny, 2016-12-06 03:52:54]

ratsunny@gmail.com changed reviewers:
+ sky@chromium.org
- sadrul@chromium.org

[sky, 2016-12-06 14:16:06]

LGTM

https://codereview.chromium.org/2546973003/diff/40001/ui/views/controls/menu/...
File ui/views/controls/menu/menu_controller.cc (right):

https://codereview.chromium.org/2546973003/diff/40001/ui/views/controls/menu/...
ui/views/controls/menu/menu_controller.cc:858: for (auto&& nested_state :
menu_stack_) {
optional: const on 858 and 859?

[Sunny, 2016-12-07 04:57:39]

https://codereview.chromium.org/2546973003/diff/40001/ui/views/controls/menu/...
File ui/views/controls/menu/menu_controller.cc (right):

https://codereview.chromium.org/2546973003/diff/40001/ui/views/controls/menu/...
ui/views/controls/menu/menu_controller.cc:858: for (auto&& nested_state :
menu_stack_) {
On 2016/12/06 14:16:06, sky wrote:
> optional: const on 858 and 859?

Hi, thanks for the review

Since 861 changes member "hot_button" in state, maybe it's not possible to make
858 and 859 const?

[sky, 2016-12-07 16:48:24]

LGTM

https://codereview.chromium.org/2546973003/diff/40001/ui/views/controls/menu/...
File ui/views/controls/menu/menu_controller.cc (right):

https://codereview.chromium.org/2546973003/diff/40001/ui/views/controls/menu/...
ui/views/controls/menu/menu_controller.cc:858: for (auto&& nested_state :
menu_stack_) {
On 2016/12/07 04:57:38, Sunny wrote:
> On 2016/12/06 14:16:06, sky wrote:
> > optional: const on 858 and 859?
> 
> Hi, thanks for the review
> 
> Since 861 changes member "hot_button" in state, maybe it's not possible to
make
> 858 and 859 const?

You are right.

[Sunny, 2016-12-07 16:58:53]

The CQ bit was checked by ratsunny@gmail.com

[commit-bot: I haz the power, 2016-12-07 16:59:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 18:00:11]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481129933526430,
"parent_rev": "adf6de3746862b9ea05b082ad71eb3c0b07be2f7", "commit_rev":
"6797e61ea496790b38dac05e8db206d9b0bb96bc"}

[commit-bot: I haz the power, 2016-12-07 18:00:40]

Description was changed from

==========
Replace unique_ptr.reset/release with std::move under src/ui

Also replace linked_ptr with unique_ptr in MenuController::NestedState

BUG=644626,556939
==========

to

==========
Replace unique_ptr.reset/release with std::move under src/ui

Also replace linked_ptr with unique_ptr in MenuController::NestedState

BUG=644626,556939
==========

[commit-bot: I haz the power, 2016-12-07 18:00:43]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-07 18:02:43]

Description was changed from

==========
Replace unique_ptr.reset/release with std::move under src/ui

Also replace linked_ptr with unique_ptr in MenuController::NestedState

BUG=644626,556939
==========

to

==========
Replace unique_ptr.reset/release with std::move under src/ui

Also replace linked_ptr with unique_ptr in MenuController::NestedState

BUG=644626,556939

Committed: https://crrev.com/14742b2f2c45a16743d0176d8e654302db6a67bf
Cr-Commit-Position: refs/heads/master@{#437001}
==========

[commit-bot: I haz the power, 2016-12-07 18:02:44]

Patchset 3 (id:??) landed as
https://crrev.com/14742b2f2c45a16743d0176d8e654302db6a67bf
Cr-Commit-Position: refs/heads/master@{#437001}