Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2546963002:
Do not move the on-screen keyboard to another display after loading an IME. (Closed)
DescriptionDo not move the on-screen keyboard to another display after loading an IME.
BUG=670617
TEST=Show the on-screen keyboard on non-touchable display and
switch to another IME; then check that the on-screen keyboard
remains on the same display.
Review-Url: https://codereview.chromium.org/2546963002
Cr-Commit-Position: refs/heads/master@{#443177}
Committed: https://chromium.googlesource.com/chromium/src/+/0635307354bc4b946cb6bf7855a9c133862f02e8
Patch Set 1 #Patch Set 2 : rebase #Patch Set 3 : rebase #
Total comments: 2
Patch Set 4 : address the comment #Patch Set 5 : rebase #Patch Set 6 : rebase #
Messages
Total messages: 35 (25 generated)
The CQ bit was checked by yhanada@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by yhanada@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by yhanada@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
yhanada@chromium.org changed reviewers: + bshe@chromium.org
Hi bshe@, PTAL.
lgtm with nit https://codereview.chromium.org/2546963002/diff/40001/ui/keyboard/keyboard_la... File ui/keyboard/keyboard_layout_manager.cc (right): https://codereview.chromium.org/2546963002/diff/40001/ui/keyboard/keyboard_la... ui/keyboard/keyboard_layout_manager.cc:87: // Do not move the keyboard to another display after loading an IME. nit: loading an IME/switch to an IME in a different extension.
Thank you for reviewing! https://codereview.chromium.org/2546963002/diff/40001/ui/keyboard/keyboard_la... File ui/keyboard/keyboard_layout_manager.cc (right): https://codereview.chromium.org/2546963002/diff/40001/ui/keyboard/keyboard_la... ui/keyboard/keyboard_layout_manager.cc:87: // Do not move the keyboard to another display after loading an IME. On 2016/12/14 16:18:28, bshe wrote: > nit: loading an IME/switch to an IME in a different extension. Done.
yhanada@chromium.org changed reviewers: + oshima@chromium.org
Hi oshima@, PTAL.
The CQ bit was checked by yhanada@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_clang on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)
lgtm Sorry, I missed this before going on vacation
Thanks for the review!
The CQ bit was checked by yhanada@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from bshe@chromium.org, oshima@chromium.org Link to the patchset: https://codereview.chromium.org/2546963002/#ps80001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
The CQ bit was checked by yhanada@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from oshima@chromium.org, bshe@chromium.org Link to the patchset: https://codereview.chromium.org/2546963002/#ps100001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 100001, "attempt_start_ts": 1484200409244230,
"parent_rev": "f3704f8df76be0e5c250db90c9faaf8eddea709f", "commit_rev":
"0635307354bc4b946cb6bf7855a9c133862f02e8"}
Message was sent while issue was closed.
Description was changed from
==========
Do not move the on-screen keyboard to another display after loading an IME.
BUG=670617
TEST=Show the on-screen keyboard on non-touchable display and
switch to another IME; then check that the on-screen keyboard
remains on the same display.
==========
to
==========
Do not move the on-screen keyboard to another display after loading an IME.
BUG=670617
TEST=Show the on-screen keyboard on non-touchable display and
switch to another IME; then check that the on-screen keyboard
remains on the same display.
Review-Url: https://codereview.chromium.org/2546963002
Cr-Commit-Position: refs/heads/master@{#443177}
Committed:
https://chromium.googlesource.com/chromium/src/+/0635307354bc4b946cb6bf7855a9...
==========
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as https://chromium.googlesource.com/chromium/src/+/0635307354bc4b946cb6bf7855a9... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
