Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Issue 2546903002: [Devtools] Fixed bug with NetworkLog depending on ResourceTreeModel

Created:
4 years ago by allada
Modified:
3 years, 5 months ago
Reviewers:
caseq, dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Devtools] Fixed bug with NetworkLog depending on ResourceTreeModel ResourceTreeModel is currently required by NetworkLog and causes a crash when a NetworkRequest tries to access it's NetworkLog because it does not exist. This bug fixes this dependency. R=dgozman,caseq BUG=668032

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -6 lines) Patch
M third_party/WebKit/Source/devtools/front_end/sdk/NetworkLog.js View 2 chunks +7 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
allada
PTL... I was going to write a test for this, but because it happens mostly ...
4 years ago (2016-12-01 23:17:23 UTC) #3
dgozman
Let's instead move page-load functionality to ResourceTreeModel? Re: https in tests. localhost is considered to ...
4 years ago (2016-12-02 18:08:22 UTC) #6
pfeldman
When/why do we have network log and not have resource tree model?
4 years ago (2016-12-02 19:48:28 UTC) #7
allada
On 2016/12/02 19:48:28, pfeldman wrote: > When/why do we have network log and not have ...
4 years ago (2016-12-03 02:28:34 UTC) #8
dgozman
3 years, 5 months ago (2017-07-15 05:41:12 UTC) #9
Should we close this?

Powered by Google App Engine
This is Rietveld 408576698