Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 2546753002: [Mac] Fix avatar bubble alignment logic (Closed)

Created:
4 years ago by lgrey
Modified:
4 years ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix avatar bubble alignment logic Fixing forward from https://codereview.chromium.org/2541583002 BUG=670181 Committed: https://crrev.com/0416ad6088bc817e1365b3ddaecc838dc01e261f Cr-Commit-Position: refs/heads/master@{#435694}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm View 1 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
lgrey
PTAL :)
4 years ago (2016-12-01 15:42:10 UTC) #2
Avi (use Gerrit)
lgtm
4 years ago (2016-12-01 15:46:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2546753002/1
4 years ago (2016-12-01 15:47:30 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/115233) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years ago (2016-12-01 15:49:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2546753002/20001
4 years ago (2016-12-01 19:43:14 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-01 20:17:46 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-01 20:19:34 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0416ad6088bc817e1365b3ddaecc838dc01e261f
Cr-Commit-Position: refs/heads/master@{#435694}

Powered by Google App Engine
This is Rietveld 408576698