Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 2546723002: [stubs] Rename index parameter to offset in CA::Load/Store operations. (Closed)

Created:
4 years ago by Igor Sheludko
Modified:
4 years ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] Rename index parameter to offset in CA::Load/Store operations. ... to avoid confusion. BUG= Committed: https://crrev.com/1bf32cf5f9e0fcac1a33fdba3f5cb3c122e77157 Cr-Commit-Position: refs/heads/master@{#41424}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -15 lines) Patch
M src/compiler/code-assembler.h View 1 chunk +5 lines, -5 lines 0 comments Download
M src/compiler/code-assembler.cc View 3 chunks +10 lines, -10 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (10 generated)
Igor Sheludko
PTAL
4 years ago (2016-12-01 12:05:01 UTC) #3
Benedikt Meurer
lgtm
4 years ago (2016-12-01 13:07:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2546723002/1
4 years ago (2016-12-01 13:07:44 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-01 13:09:22 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-01 13:09:46 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1bf32cf5f9e0fcac1a33fdba3f5cb3c122e77157
Cr-Commit-Position: refs/heads/master@{#41424}

Powered by Google App Engine
This is Rietveld 408576698