Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 2544713003: [stubs] Remove representation parameter from Store() operations that trigger full write barrier. (Closed)

Created:
4 years ago by Igor Sheludko
Modified:
4 years ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] Remove representation parameter from Store() operations that trigger full write barrier. ... because only MachineRepresentation::kTagged makes sense there. BUG= Committed: https://crrev.com/c2f526849b8bc8e55af6a72c45baa831effd12af Cr-Commit-Position: refs/heads/master@{#41426}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -21 lines) Patch
M src/code-stub-assembler.cc View 6 chunks +9 lines, -11 lines 0 comments Download
M src/compiler/code-assembler.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/code-assembler.cc View 1 chunk +6 lines, -5 lines 0 comments Download
M src/ic/keyed-store-generic.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (8 generated)
Igor Sheludko
PTAL
4 years ago (2016-12-01 12:32:07 UTC) #4
Benedikt Meurer
lgtm
4 years ago (2016-12-01 13:06:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2544713003/1
4 years ago (2016-12-01 13:10:28 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-01 13:12:05 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-01 13:12:21 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c2f526849b8bc8e55af6a72c45baa831effd12af
Cr-Commit-Position: refs/heads/master@{#41426}

Powered by Google App Engine
This is Rietveld 408576698