Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 2546653006: [Merge m56][autofill] Merge can select the wrong address. (Closed)

Created:
4 years ago by Mathieu
Modified:
4 years ago
Reviewers:
Mathieu
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

[Merge m56][autofill] Merge can select the wrong address. Fixes a bug where, in the case where the the second address should have been retained during merge, the first address is retained, due to a typo in the referenced variable name. BUG=669925 R=mathp@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2535103004 Cr-Commit-Position: refs/branch-heads/2883@{#700} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} (cherry picked from commit 3cb0576de6902976d1b4271e0673aac0caa641fa) Committed: https://chromium.googlesource.com/chromium/src/+/8951973f96b7dba48c5cf3406fa0650beced8e5b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M components/autofill/core/browser/autofill_profile_comparator.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
Mathieu
4 years ago (2016-12-02 18:33:18 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8951973f96b7dba48c5cf3406fa0650beced8e5b.

Powered by Google App Engine
This is Rietveld 408576698