Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2535103004:
[autofill] Merge can select the wrong address. (Closed)
|
Created:
4 years ago by Roger McFarlane (Chromium) Modified:
4 years ago Reviewers:
Mathieu CC:
chromium-reviews, rouslan+autofill_chromium.org, estade+watch_chromium.org, vabr+watchlistautofill_chromium.org, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org Target Ref:
refs/pending/branch-heads/2883 Project:
chromium Visibility:
Public. |
Description[autofill] Merge can select the wrong address.
Fixes a bug where, in the case where the the second address
should have been retained during merge, the first address is
retained, due to a typo in the referenced variable name.
BUG=669925
R=mathp@chromium.org
NOTRY=true
NOPRESUBMIT=true
Patch Set 1 #
Messages
Total messages: 19 (12 generated)
The CQ bit was checked by rogerm@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for the CQ to process them
PTAL?
Note that this bug was found a fixed while working on https://codereview.chromium.org/2493253002/ which included expanded unit-tests. This CL captures the 1 line change to fix the bad address selection without any of the other features work from the other CL. For merge to M55.
The CQ bit was checked by mathp@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for the CQ to process them
Description was changed from ========== [autofill] Merge can select the wrong address. Fixes a bug where, in the case where the the second address should have been retained during merge, the first address is retained, due to a typo in the referenced variable name. BUG=669925 R=mathp@chromium.org ========== to ========== [autofill] Merge can select the wrong address. Fixes a bug where, in the case where the the second address should have been retained during merge, the first address is retained, due to a typo in the referenced variable name. BUG=669925 R=mathp@chromium.org NOTRY=true NOPRESUBMIT=true ==========
The CQ bit was checked by mathp@chromium.org
The CQ bit was unchecked by mathp@chromium.org
The CQ bit was checked by rogerm@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1480565892115640, "parent_rev":
"904ee3663d6a0ef6f7d090307c64c7d492104127", "commit_rev":
"3835f490df1201efd63d8c7fdcd434290dbf7955"}
Message was sent while issue was closed.
Description was changed from ========== [autofill] Merge can select the wrong address. Fixes a bug where, in the case where the the second address should have been retained during merge, the first address is retained, due to a typo in the referenced variable name. BUG=669925 R=mathp@chromium.org NOTRY=true NOPRESUBMIT=true ========== to ========== [autofill] Merge can select the wrong address. Fixes a bug where, in the case where the the second address should have been retained during merge, the first address is retained, due to a typo in the referenced variable name. BUG=669925 R=mathp@chromium.org NOTRY=true NOPRESUBMIT=true ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
