Enable hermetic builds for iOS.

Enable hermetic builds for iOS.

BUG=669094
Committed: https://crrev.com/080de20fe53a35ec6b5ce89470261157f9389db3
Cr-Commit-Position: refs/heads/master@{#437269}

[justincohen, 2016-12-01 17:57:20]

The CQ bit was checked by justincohen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 17:57:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[justincohen, 2016-12-01 17:58:17]

Description was changed from

==========
Enable hermetic builds for iOS.

BUG=
==========

to

==========
Enable hermetic builds for iOS.

BUG=669094
==========

[justincohen, 2016-12-01 18:41:03]

justincohen@chromium.org changed reviewers:
+ erikchen@chromium.org

[justincohen, 2016-12-01 18:41:04]

This needs to land after https://codereview.chromium.org/2544803002/, which
fixes compilation from within Xcode's hybrid project that shells out to ninja.

PTAL

[commit-bot: I haz the power, 2016-12-01 19:57:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 19:57:23]

Dry run: This issue passed the CQ dry run.

[justincohen, 2016-12-01 20:26:56]

When I ssh into build422-m4 I see -isysroot
/Applications/Xcode8.0.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator10.0.sdk,
so I guess it's not working

[justincohen, 2016-12-03 00:47:58]

Patchset #3 (id:40001) has been deleted

[justincohen, 2016-12-03 00:48:03]

Patchset #2 (id:20001) has been deleted

[justincohen, 2016-12-03 00:53:09]

After updating infra scripts to set FORCE_MAC_TOOLCHAIN, this is now working.

sshing to the bots shows:
 -isysroot
/b/build/slave/ios-simulator/build/src/build/mac_files/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator10.1.sdk

PTAL!

[justincohen, 2016-12-04 17:14:13]

erikchen@ for reviewer
kjellander@ for OWNERS

ptal

[justincohen, 2016-12-04 17:14:20]

justincohen@chromium.org changed reviewers:
+ kjellander@chromium.org

[justincohen, 2016-12-04 17:14:20]

erikchen@ for reviewer
kjellander@ for OWNERS

ptal

[kjellander_chromium, 2016-12-05 07:40:32]

lgtm 

(this won't affect WebRTC since we set use_system_xcode=true due to the "ld:
library not found for -lc++" error, see http://crbug.com/633032)

[sdefresne, 2016-12-06 13:22:53]

sdefresne@chromium.org changed reviewers:
+ sdefresne@chromium.org

[sdefresne, 2016-12-06 13:22:53]

lgtm

I was able to build downstream from Xcode and from command-line with this
patchset.

[sdefresne, 2016-12-06 13:36:00]

On 2016/12/06 13:22:53, sdefresne wrote:
> lgtm
> 
> I was able to build downstream from Xcode and from command-line with this
> patchset.

Note that goma is unable to build when applying the patch and all files fall
back to local build. Maybe worth investigating before landing this CL.

[justincohen, 2016-12-06 17:50:10]

I'm able to build with goma...  any more details on the failure?

[justincohen, 2016-12-06 19:39:27]

erikchen: ptal, disabled the IsCorpMachine for iOS users (mac only), since
hermetic may interfere with CoreSimulatorService when Xcode.app is running,
which pretty much all iOS developers run.

[erikchen, 2016-12-06 20:07:55]

https://codereview.chromium.org/2546613004/diff/60001/build/mac/should_use_he...
File build/mac/should_use_hermetic_xcode.py (right):

https://codereview.chromium.org/2546613004/diff/60001/build/mac/should_use_he...
build/mac/should_use_hermetic_xcode.py:18: allow_corp = sys.argv[1] == "mac" and
_IsCorpMachine()
Update documentation for this script?

[justincohen, 2016-12-06 20:51:34]

ptal

https://codereview.chromium.org/2546613004/diff/60001/build/mac/should_use_he...
File build/mac/should_use_hermetic_xcode.py (right):

https://codereview.chromium.org/2546613004/diff/60001/build/mac/should_use_he...
build/mac/should_use_hermetic_xcode.py:18: allow_corp = sys.argv[1] == "mac" and
_IsCorpMachine()
On 2016/12/06 20:07:55, erikchen wrote:
> Update documentation for this script?

Done.

[sdefresne, 2016-12-07 10:56:28]

On 2016/12/06 20:51:34, justincohen wrote:
> ptal
> 
>
https://codereview.chromium.org/2546613004/diff/60001/build/mac/should_use_he...
> File build/mac/should_use_hermetic_xcode.py (right):
> 
>
https://codereview.chromium.org/2546613004/diff/60001/build/mac/should_use_he...
> build/mac/should_use_hermetic_xcode.py:18: allow_corp = sys.argv[1] == "mac"
and
> _IsCorpMachine()
> On 2016/12/06 20:07:55, erikchen wrote:
> > Update documentation for this script?
> 
> Done.

I was able to build with goma, except that all succeeded in state
LOCAL_FALLBACK.

[sdefresne, 2016-12-07 14:19:16]

After out-of-band discussion, it is likely that the goma failure were unrelated.
lgtm

[erikchen, 2016-12-07 19:52:26]

lgtm

[justincohen, 2016-12-07 19:53:34]

justincohen@chromium.org changed reviewers:
+ rsesek@chromium.org

[justincohen, 2016-12-07 19:53:34]

rsesek@ for mac OWNERS ptal

[Robert Sesek, 2016-12-07 19:55:44]

LGTM

https://codereview.chromium.org/2546613004/diff/80001/build/mac/should_use_he...
File build/mac/should_use_hermetic_xcode.py (right):

https://codereview.chromium.org/2546613004/diff/80001/build/mac/should_use_he...
build/mac/should_use_hermetic_xcode.py:10: python should_user-hermetic_xcode.py
<target_os>
nit: typo here

https://codereview.chromium.org/2546613004/diff/80001/build/mac/should_use_he...
build/mac/should_use_hermetic_xcode.py:22: allow_corp = sys.argv[1] == "mac" and
_IsCorpMachine()
nit: single quotes for mac ?

[justincohen, 2016-12-08 03:25:15]

https://codereview.chromium.org/2546613004/diff/80001/build/mac/should_use_he...
File build/mac/should_use_hermetic_xcode.py (right):

https://codereview.chromium.org/2546613004/diff/80001/build/mac/should_use_he...
build/mac/should_use_hermetic_xcode.py:10: python should_user-hermetic_xcode.py
<target_os>
On 2016/12/07 19:55:44, Robert Sesek wrote:
> nit: typo here

Done.

https://codereview.chromium.org/2546613004/diff/80001/build/mac/should_use_he...
build/mac/should_use_hermetic_xcode.py:22: allow_corp = sys.argv[1] == "mac" and
_IsCorpMachine()
On 2016/12/07 19:55:44, Robert Sesek wrote:
> nit: single quotes for mac ?

Done.

[justincohen, 2016-12-08 03:25:20]

The CQ bit was checked by justincohen@chromium.org

[justincohen, 2016-12-08 03:25:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
kjellander@chromium.org, rsesek@chromium.org, erikchen@chromium.org,
sdefresne@chromium.org
Link to the patchset: https://codereview.chromium.org/2546613004/#ps100001
(title: "Address rsesek comments")

[commit-bot: I haz the power, 2016-12-08 03:25:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 04:59:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 04:59:37]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[justincohen, 2016-12-08 05:00:55]

The CQ bit was checked by justincohen@chromium.org

[commit-bot: I haz the power, 2016-12-08 05:01:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 06:25:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 06:25:02]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[justincohen, 2016-12-08 12:53:38]

The CQ bit was checked by justincohen@chromium.org

[commit-bot: I haz the power, 2016-12-08 12:53:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 14:05:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 14:05:18]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[justincohen, 2016-12-08 14:48:23]

The CQ bit was checked by justincohen@chromium.org

[commit-bot: I haz the power, 2016-12-08 14:48:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 15:57:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 15:57:58]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[justincohen, 2016-12-08 15:58:21]

The CQ bit was checked by justincohen@chromium.org

[commit-bot: I haz the power, 2016-12-08 15:58:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 17:15:11]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1481212701616650,
"parent_rev": "66d1179da4de670fb493684626a36757d42c7131", "commit_rev":
"b1bece5c1ac233dc04ae68d8e3bb0c51fb846fe5"}

[commit-bot: I haz the power, 2016-12-08 17:15:36]

Description was changed from

==========
Enable hermetic builds for iOS.

BUG=669094
==========

to

==========
Enable hermetic builds for iOS.

BUG=669094
==========

[commit-bot: I haz the power, 2016-12-08 17:15:38]

Committed patchset #4 (id:100001)

[commit-bot: I haz the power, 2016-12-08 17:17:41]

Description was changed from

==========
Enable hermetic builds for iOS.

BUG=669094
==========

to

==========
Enable hermetic builds for iOS.

BUG=669094

Committed: https://crrev.com/080de20fe53a35ec6b5ce89470261157f9389db3
Cr-Commit-Position: refs/heads/master@{#437269}
==========

[commit-bot: I haz the power, 2016-12-08 17:17:42]

Patchset 4 (id:??) landed as
https://crrev.com/080de20fe53a35ec6b5ce89470261157f9389db3
Cr-Commit-Position: refs/heads/master@{#437269}

[justincohen, 2016-12-08 17:25:49]

A revert of this CL (patchset #4 id:100001) has been created in
https://codereview.chromium.org/2552383006/ by justincohen@chromium.org.

The reason for reverting is: IndexError: list index out of range.