Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1467)

Unified Diff: build_overrides/build.gni

Issue 2546613004: Enable hermetic builds for iOS. (Closed)
Patch Set: Address rsesek comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/mac/should_use_hermetic_xcode.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build_overrides/build.gni
diff --git a/build_overrides/build.gni b/build_overrides/build.gni
index a7cd058756591b58e2556af74a8268457632364a..e88dfc98383306d45021f89ce5fedeedc2c75059 100644
--- a/build_overrides/build.gni
+++ b/build_overrides/build.gni
@@ -46,12 +46,8 @@ declare_args() {
}
if (use_system_xcode == "") {
- if (target_os == "mac") {
- _result =
- exec_script("//build/mac/should_use_hermetic_xcode.py", [], "value")
- use_system_xcode = _result == 0
- }
- if (target_os == "ios") {
- use_system_xcode = true
- }
+ _result = exec_script("//build/mac/should_use_hermetic_xcode.py",
+ [ target_os ],
+ "value")
+ use_system_xcode = _result == 0
}
« no previous file with comments | « build/mac/should_use_hermetic_xcode.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698