Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2546593002: [blimp] Fix package name in shell script for running blimp (Closed)

Created:
4 years ago by nyquist
Modified:
4 years ago
CC:
chromium-reviews, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[blimp] Fix package name in shell script for running blimp The shell script for running Blimp on a device is supposed to match the checked in Activity to start. However, after https://codereview.chromium.org/2493333002/ landed, the package name was not updated. This leads to the script not starting Blimp correctly. The CL updates to the new package name. BUG= Committed: https://crrev.com/eea22ff30ee62572ae6a809abaeb1573314b4f66 Cr-Commit-Position: refs/heads/master@{#435505}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/android/adb_run_blimp_client View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
nyquist
rnephew: PTAL
4 years ago (2016-12-01 00:41:32 UTC) #3
rnephew (Reviews Here)
On 2016/12/01 00:41:32, nyquist wrote: > rnephew: PTAL lgtm
4 years ago (2016-12-01 00:42:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2546593002/1
4 years ago (2016-12-01 00:44:20 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-01 00:54:51 UTC) #9
commit-bot: I haz the power
4 years ago (2016-12-01 00:58:28 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eea22ff30ee62572ae6a809abaeb1573314b4f66
Cr-Commit-Position: refs/heads/master@{#435505}

Powered by Google App Engine
This is Rietveld 408576698