Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 2493333002: Move Java Blimp shell code to app subpackage (Closed)

Created:
4 years, 1 month ago by nyquist
Modified:
4 years, 1 month ago
CC:
chromium-reviews, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, bgoldman+watch-blimp_chromium.org, steimel+watch-blimp_chromium.org, gcasto+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, perumaal+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, lethalantidote+watch-blimp_chromium.org, agrieve+watch_chromium.org, dtrainor+watch-blimp_chromium.org, scf+watch-blimp_chromium.org, khushalsagar+watch-blimp_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move Java Blimp shell code to app subpackage - Moves org.chromium.blimp app code to org.chromium.blimp.app. - Moved org.chromium.blimp resources to org.chromium.blimp.app.R - Renames BlimpView to BlimpContentsDisplay - Formats all edited code. BUG=651964 Committed: https://crrev.com/4494b26d5714a9492be7de380ba8012513d8f2ee Cr-Commit-Position: refs/heads/master@{#431989}

Patch Set 1 #

Patch Set 2 : Fix build and XML issues #

Patch Set 3 : Fix usage of AlertDialog #

Patch Set 4 : Merge branch 'refs/heads/master' into blimp-shell-integration #

Unified diffs Side-by-side diffs Delta from patch set Stats (+213 lines, -3264 lines) Patch
M blimp/client/app/BUILD.gn View 1 2 6 chunks +29 lines, -28 lines 0 comments Download
M blimp/client/app/android/AndroidManifest.xml.jinja2 View 1 2 chunks +4 lines, -4 lines 0 comments Download
M blimp/client/app/android/blimp_app_jni_registrar.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + blimp/client/app/android/blimp_contents_display.h View 5 chunks +17 lines, -16 lines 0 comments Download
A + blimp/client/app/android/blimp_contents_display.cc View 10 chunks +37 lines, -53 lines 0 comments Download
D blimp/client/app/android/blimp_view.h View 1 chunk +0 lines, -126 lines 0 comments Download
D blimp/client/app/android/blimp_view.cc View 1 chunk +0 lines, -222 lines 0 comments Download
M blimp/client/app/android/java/res/layout/blimp_main.xml View 1 4 chunks +6 lines, -6 lines 0 comments Download
D blimp/client/app/android/java/src/org/chromium/blimp/BlimpApplication.java View 1 chunk +0 lines, -39 lines 0 comments Download
D blimp/client/app/android/java/src/org/chromium/blimp/BlimpLibraryLoader.java View 1 chunk +0 lines, -126 lines 0 comments Download
D blimp/client/app/android/java/src/org/chromium/blimp/BlimpRendererActivity.java View 1 chunk +0 lines, -341 lines 0 comments Download
D blimp/client/app/android/java/src/org/chromium/blimp/BlimpView.java View 1 chunk +0 lines, -207 lines 0 comments Download
D blimp/client/app/android/java/src/org/chromium/blimp/BrowserRestartActivity.java View 1 chunk +0 lines, -74 lines 0 comments Download
A + blimp/client/app/android/java/src/org/chromium/blimp/app/BlimpApplication.java View 1 chunk +1 line, -1 line 0 comments Download
A + blimp/client/app/android/java/src/org/chromium/blimp/app/BlimpContentsDisplay.java View 10 chunks +45 lines, -54 lines 0 comments Download
A + blimp/client/app/android/java/src/org/chromium/blimp/app/BlimpLibraryLoader.java View 1 chunk +1 line, -1 line 0 comments Download
A + blimp/client/app/android/java/src/org/chromium/blimp/app/BlimpRendererActivity.java View 7 chunks +19 lines, -19 lines 0 comments Download
A + blimp/client/app/android/java/src/org/chromium/blimp/app/BrowserRestartActivity.java View 1 chunk +1 line, -1 line 0 comments Download
A + blimp/client/app/android/java/src/org/chromium/blimp/app/auth/RetryingTokenSource.java View 1 chunk +1 line, -1 line 0 comments Download
A + blimp/client/app/android/java/src/org/chromium/blimp/app/auth/TokenSource.java View 1 chunk +1 line, -1 line 0 comments Download
A + blimp/client/app/android/java/src/org/chromium/blimp/app/auth/TokenSourceImpl.java View 2 chunks +2 lines, -2 lines 0 comments Download
A + blimp/client/app/android/java/src/org/chromium/blimp/app/preferences/PreferencesUtil.java View 2 chunks +4 lines, -4 lines 0 comments Download
A + blimp/client/app/android/java/src/org/chromium/blimp/app/session/BlimpClientSession.java View 1 chunk +2 lines, -2 lines 0 comments Download
A + blimp/client/app/android/java/src/org/chromium/blimp/app/session/EngineInfo.java View 1 chunk +1 line, -1 line 0 comments Download
A + blimp/client/app/android/java/src/org/chromium/blimp/app/session/TabControlFeature.java View 2 chunks +3 lines, -3 lines 0 comments Download
A + blimp/client/app/android/java/src/org/chromium/blimp/app/settings/AboutBlimpPreferences.java View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
A + blimp/client/app/android/java/src/org/chromium/blimp/app/settings/Preferences.java View 1 chunk +1 line, -1 line 0 comments Download
A + blimp/client/app/android/java/src/org/chromium/blimp/app/toolbar/Toolbar.java View 2 chunks +3 lines, -3 lines 0 comments Download
A + blimp/client/app/android/java/src/org/chromium/blimp/app/toolbar/ToolbarMenu.java View 2 chunks +6 lines, -6 lines 0 comments Download
A + blimp/client/app/android/java/src/org/chromium/blimp/app/toolbar/UrlBar.java View 2 chunks +2 lines, -2 lines 0 comments Download
D blimp/client/app/android/java/src/org/chromium/blimp/auth/RetryingTokenSource.java View 1 chunk +0 lines, -170 lines 0 comments Download
D blimp/client/app/android/java/src/org/chromium/blimp/auth/TokenSource.java View 1 chunk +0 lines, -89 lines 0 comments Download
D blimp/client/app/android/java/src/org/chromium/blimp/auth/TokenSourceImpl.java View 1 chunk +0 lines, -184 lines 0 comments Download
D blimp/client/app/android/java/src/org/chromium/blimp/preferences/PreferencesUtil.java View 1 chunk +0 lines, -76 lines 0 comments Download
D blimp/client/app/android/java/src/org/chromium/blimp/session/BlimpClientSession.java View 1 chunk +0 lines, -187 lines 0 comments Download
D blimp/client/app/android/java/src/org/chromium/blimp/session/EngineInfo.java View 1 chunk +0 lines, -29 lines 0 comments Download
D blimp/client/app/android/java/src/org/chromium/blimp/session/TabControlFeature.java View 1 chunk +0 lines, -67 lines 0 comments Download
D blimp/client/app/android/java/src/org/chromium/blimp/settings/AboutBlimpPreferences.java View 1 chunk +0 lines, -137 lines 0 comments Download
D blimp/client/app/android/java/src/org/chromium/blimp/settings/Preferences.java View 1 chunk +0 lines, -24 lines 0 comments Download
D blimp/client/app/android/java/src/org/chromium/blimp/toolbar/Toolbar.java View 1 chunk +0 lines, -238 lines 0 comments Download
D blimp/client/app/android/java/src/org/chromium/blimp/toolbar/ToolbarMenu.java View 1 chunk +0 lines, -195 lines 0 comments Download
D blimp/client/app/android/java/src/org/chromium/blimp/toolbar/UrlBar.java View 1 chunk +0 lines, -81 lines 0 comments Download
D blimp/client/app/android/javatests/src/org/chromium/blimp/BlimpNativeInstrumentationTestCase.java View 1 chunk +0 lines, -52 lines 0 comments Download
A + blimp/client/app/android/javatests/src/org/chromium/blimp/app/BlimpNativeInstrumentationTestCase.java View 1 chunk +1 line, -1 line 0 comments Download
A + blimp/client/app/android/javatests/src/org/chromium/blimp/app/auth/MockTokenSource.java View 2 chunks +3 lines, -3 lines 0 comments Download
A + blimp/client/app/android/javatests/src/org/chromium/blimp/app/auth/RetryingTokenSourceTest.java View 8 chunks +16 lines, -24 lines 0 comments Download
D blimp/client/app/android/javatests/src/org/chromium/blimp/auth/MockTokenSource.java View 1 chunk +0 lines, -97 lines 0 comments Download
D blimp/client/app/android/javatests/src/org/chromium/blimp/auth/RetryingTokenSourceTest.java View 1 chunk +0 lines, -259 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
David Trainor- moved to gerrit
lgtm!
4 years, 1 month ago (2016-11-11 23:02:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2493333002/20001
4 years, 1 month ago (2016-11-12 01:38:33 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/302893)
4 years, 1 month ago (2016-11-12 01:47:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2493333002/60001
4 years, 1 month ago (2016-11-14 21:12:34 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 1 month ago (2016-11-14 23:53:21 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-14 23:58:24 UTC) #15
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/4494b26d5714a9492be7de380ba8012513d8f2ee
Cr-Commit-Position: refs/heads/master@{#431989}

Powered by Google App Engine
This is Rietveld 408576698