Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1371)

Unified Diff: content/public/browser/render_frame_host.h

Issue 2546533007: Store the last committed origin in RenderFrameHostImpl. (Closed)
Patch Set: Rebase (and remove DCHECK) Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/render_frame_host.h
diff --git a/content/public/browser/render_frame_host.h b/content/public/browser/render_frame_host.h
index d1dbaa6f00f621bffc348ac039c34b60d45120c1..9c568d0c5795097f2557046ac362bc80a1b142ba 100644
--- a/content/public/browser/render_frame_host.h
+++ b/content/public/browser/render_frame_host.h
@@ -111,13 +111,7 @@ class CONTENT_EXPORT RenderFrameHost : public IPC::Listener,
virtual const GURL& GetLastCommittedURL() = 0;
// Returns the last committed origin of the frame.
- //
- // The origin is only available if this RenderFrameHost is current in the
- // frame tree -- i.e., it would be visited by WebContents::ForEachFrame. In
- // particular, this method may CHECK if called from
- // WebContentsObserver::RenderFrameCreated, since non-current frames can be
- // passed to that observer method.
- virtual url::Origin GetLastCommittedOrigin() = 0;
+ virtual const url::Origin& GetLastCommittedOrigin() = 0;
alexmos 2016/12/06 17:22:40 We should be able to remove the hack introduced in
Charlie Reis 2016/12/08 19:51:47 Acknowledged.
// Returns the associated widget's native view.
virtual gfx::NativeView GetNativeView() = 0;

Powered by Google App Engine
This is Rietveld 408576698