[Media Router] Crasher fix for PresentationServiceDelegateImpl.

[Media Router] Crasher fix for PresentationServiceDelegateImpl.

Check that the RFH corresponds to a "current" frame before requesting the last
committed origin.

BUG=663740
Committed: https://crrev.com/ed3161f4bd859866648b9cd9f211b74fcf5f0a6c
Cr-Commit-Position: refs/heads/master@{#436399}

[mark a. foltz, 2016-12-03 00:16:02]

mfoltz@chromium.org changed reviewers:
+ imcheng@chromium.org

[imcheng, 2016-12-05 19:53:22]

lgtm

Hmm, it looks like the crash is caused by RFH receiving the PresentationService
mojo call after it has been marked for deletion. I wonder if for longer term fix
we should be checking for validity of the frame (IsRenderFrameLive?) at the
PSImpl level?

[mark a. foltz, 2016-12-05 20:00:42]

On 2016/12/05 at 19:53:22, imcheng wrote:
> lgtm
> 
> Hmm, it looks like the crash is caused by RFH receiving the
PresentationService mojo call after it has been marked for deletion. I wonder if
for longer term fix we should be checking for validity of the frame
(IsRenderFrameLive?) at the PSImpl level?

Not sure.  A render frame host may exist for a frame that is not attached to the
node tree and/or marked for deletion.  These do not have a well defined origin
accessible via the RFH.

The long term fix could be for PresentationFrame to keep track of a current
frame node (via FrameNodeId) instead of render frame host id, but this may
prevent the API from working in detached frames.

These APIs are a moving target with the OOPIF work.  I can sync with them to try
to find out what the plan is.

[mark a. foltz, 2016-12-05 20:00:50]

The CQ bit was checked by mfoltz@chromium.org

[commit-bot: I haz the power, 2016-12-05 20:02:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-05 21:04:16]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1480968050846740, "parent_rev":
"22798c65004ee78d922a82f965591d0c2d2770ff", "commit_rev":
"8bdfe6ad441772d29941024de9bc7739a70435b2"}

[commit-bot: I haz the power, 2016-12-05 21:05:05]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-05 21:06:43]

Description was changed from

==========
[Media Router] Crasher fix for PresentationServiceDelegateImpl.

Check that the RFH corresponds to a "current" frame before requesting the last
committed origin.

BUG=663740
==========

to

==========
[Media Router] Crasher fix for PresentationServiceDelegateImpl.

Check that the RFH corresponds to a "current" frame before requesting the last
committed origin.

BUG=663740

Committed: https://crrev.com/ed3161f4bd859866648b9cd9f211b74fcf5f0a6c
Cr-Commit-Position: refs/heads/master@{#436399}
==========

[commit-bot: I haz the power, 2016-12-05 21:06:43]

Patchset 1 (id:??) landed as
https://crrev.com/ed3161f4bd859866648b9cd9f211b74fcf5f0a6c
Cr-Commit-Position: refs/heads/master@{#436399}