Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Unified Diff: components/network_session_configurator/network_session_configurator_unittest.cc

Issue 2546533003: Respect QuicAllowed policy for new streams (Closed)
Patch Set: IOS io_thread also initializes DynamicSharedParams Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/network_session_configurator/network_session_configurator_unittest.cc
diff --git a/components/network_session_configurator/network_session_configurator_unittest.cc b/components/network_session_configurator/network_session_configurator_unittest.cc
index ccea4fbcb5caf5b4369b66bc6feab1548fa02bab..e6be1181eafe02747dade2a743f3ef476c62c3d3 100644
--- a/components/network_session_configurator/network_session_configurator_unittest.cc
+++ b/components/network_session_configurator/network_session_configurator_unittest.cc
@@ -25,6 +25,8 @@ class NetworkSessionConfiguratorTest : public testing::Test {
new base::FieldTrialList(
base::MakeUnique<base::MockEntropyProvider>()));
variations::testing::ClearAllVariationParams();
+
+ params_.dynamic_shared_params = &dynamic_shared_params_;
}
void ParseFieldTrials() {
@@ -36,6 +38,7 @@ class NetworkSessionConfiguratorTest : public testing::Test {
std::string quic_user_agent_id_;
std::unique_ptr<base::FieldTrialList> field_trial_list_;
net::HttpNetworkSession::Params params_;
+ net::HttpNetworkSession::DynamicSharedParams dynamic_shared_params_;
};
TEST_F(NetworkSessionConfiguratorTest, Defaults) {
@@ -48,7 +51,7 @@ TEST_F(NetworkSessionConfiguratorTest, Defaults) {
EXPECT_TRUE(params_.enable_http2);
EXPECT_FALSE(params_.enable_tcp_fast_open_for_ssl);
EXPECT_TRUE(params_.enable_quic_alternative_service_with_different_host);
- EXPECT_FALSE(params_.enable_quic);
+ EXPECT_FALSE(params_.enable_quic());
}
TEST_F(NetworkSessionConfiguratorTest, Http2FieldTrialHttp2Disable) {
@@ -64,7 +67,7 @@ TEST_F(NetworkSessionConfiguratorTest, EnableQuicFromFieldTrialGroup) {
ParseFieldTrials();
- EXPECT_TRUE(params_.enable_quic);
+ EXPECT_TRUE(params_.enable_quic());
EXPECT_FALSE(params_.disable_quic_on_timeout_with_open_streams);
EXPECT_EQ(1350u, params_.quic_max_packet_length);
EXPECT_EQ(net::QuicTagVector(), params_.quic_connection_options);
@@ -104,7 +107,7 @@ TEST_F(NetworkSessionConfiguratorTest, EnableQuicForDataReductionProxy) {
ParseFieldTrials();
- EXPECT_TRUE(params_.enable_quic);
+ EXPECT_TRUE(params_.enable_quic());
}
TEST_F(NetworkSessionConfiguratorTest,

Powered by Google App Engine
This is Rietveld 408576698